-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stmtsummary: reduce the memory consumption by information_schema.statements_summary_evicted #56722
Conversation
Hi @crazycs520. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #56722 +/- ##
=================================================
- Coverage 73.3262% 57.9024% -15.4239%
=================================================
Files 1630 1786 +156
Lines 450312 647923 +197611
=================================================
+ Hits 330197 375163 +44966
- Misses 99833 247557 +147724
- Partials 20282 25203 +4921
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…ements_summary_evicted Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
[LGTM Timeline notifier]Timeline:
|
/retest-required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GMHDBJD, lcwangchao, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #56629
Problem Summary: reduce the memory consumption by information_schema.statements_summary_evicted
What changed and how does it work?
Remove the digest map of
statements_summary_evicted
, use a counter to count evicted digest.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.