Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: Move tiflashScanContext outof basic stats #56742

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

yibin87
Copy link
Contributor

@yibin87 yibin87 commented Oct 21, 2024

What problem does this PR solve?

Issue Number: close #56743

Problem Summary:

What changed and how does it work?

BasicRuntimeStats is a general structure used for all executors including tidb ones, it is a waste of resource to record the info here.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 21, 2024
Copy link

tiprow bot commented Oct 21, 2024

Hi @yibin87. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: yibin <[email protected]>
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 95.52239% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.2192%. Comparing base (73584bb) to head (1db3897).
Report is 2 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56742         +/-   ##
=================================================
- Coverage   73.3422%   56.2192%   -17.1231%     
=================================================
  Files          1630       1756        +126     
  Lines        450364     630119     +179755     
=================================================
+ Hits         330307     354248      +23941     
- Misses        99779     251889     +152110     
- Partials      20278      23982       +3704     
Flag Coverage Δ
integration 36.7362% <86.5671%> (?)
unit 72.4451% <95.5223%> (-0.0242%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.5028% <ø> (+6.9434%) ⬆️

@yibin87
Copy link
Contributor Author

yibin87 commented Oct 21, 2024

/cc @xzhangxian1008 @windtalker

Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 21, 2024
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

ti-chi-bot bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, xzhangxian1008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 21, 2024
Copy link

ti-chi-bot bot commented Oct 21, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-21 07:25:43.262502787 +0000 UTC m=+249543.959293390: ☑️ agreed by xzhangxian1008.
  • 2024-10-21 07:43:07.587161719 +0000 UTC m=+250588.283952330: ☑️ agreed by windtalker.

Signed-off-by: yibin <[email protected]>
@ti-chi-bot ti-chi-bot bot merged commit dfd6cf2 into pingcap:master Oct 21, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move TiFlashScanContext out of BasicRuntimeStats
3 participants