Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: fix br integration test file corruption #56799

Merged

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Oct 23, 2024

What problem does this PR solve?

Issue Number: close #53835

Problem Summary:
The log file may not be restored so sometimes corrupting one log file does not make restore fail.

What changed and how does it work?

lost/corrupt all the files.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 23, 2024
Copy link

tiprow bot commented Oct 23, 2024

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.4799%. Comparing base (ba5823b) to head (b318a65).
Report is 60 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56799         +/-   ##
=================================================
- Coverage   73.3727%   57.4799%   -15.8929%     
=================================================
  Files          1635       1761        +126     
  Lines        452770     638477     +185707     
=================================================
+ Hits         332210     366996      +34786     
- Misses       100208     247135     +146927     
- Partials      20352      24346       +3994     
Flag Coverage Δ
integration 38.8810% <ø> (?)
unit 73.1888% <ø> (+0.6962%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 63.0958% <ø> (+17.0727%) ⬆️

Signed-off-by: Jianjun Liao <[email protected]>
@Leavrth
Copy link
Contributor Author

Leavrth commented Oct 24, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Oct 24, 2024

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Tristan1900
Copy link
Contributor

/lgtm

Copy link

ti-chi-bot bot commented Oct 24, 2024

@Tristan1900: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Leavrth
Copy link
Contributor Author

Leavrth commented Oct 28, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Oct 28, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 28, 2024
Copy link

ti-chi-bot bot commented Oct 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, Tristan1900, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 28, 2024
Copy link

ti-chi-bot bot commented Oct 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-28 02:33:20.516228028 +0000 UTC m=+230713.355383574: ☑️ agreed by YuJuncen.
  • 2024-10-28 02:43:13.569592845 +0000 UTC m=+231306.408748388: ☑️ agreed by 3pointer.

@Leavrth
Copy link
Contributor Author

Leavrth commented Oct 28, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit c7d09e6 into pingcap:master Oct 28, 2024
24 checks passed
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Oct 31, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 31, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #57029.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix unstable integration test for br
5 participants