-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: enable the ddl notifier by default #56864
ddl: enable the ddl notifier by default #56864
Conversation
Signed-off-by: Rustin170506 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #56864 +/- ##
=================================================
- Coverage 73.3393% 57.2836% -16.0558%
=================================================
Files 1636 1791 +155
Lines 453658 641845 +188187
=================================================
+ Hits 332710 367672 +34962
- Misses 100561 249028 +148467
- Partials 20387 25145 +4758
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Rustin170506 <[email protected]>
Signed-off-by: Rustin170506 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔢 Self-check (PR reviewed by myself and ready for feedback.)
Tested locally:
mysql> use test
Database changed
mysql> select * from mysql.tidb_ddl_notifier;
Empty set (0.00 sec)
mysql> create table a(a int);
Query OK, 0 rows affected (0.02 sec)
mysql> select * from mysql.tidb_ddl_notifier;
Empty set (0.00 sec)
mysql> ALTER TABLE a ADD INDEX index_name (a);
Query OK, 0 rows affected (0.10 sec)
mysql> select * from mysql.tidb_ddl_notifier;
Empty set (0.00 sec) |
Signed-off-by: Rustin170506 <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fzzf678, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What problem does this PR solve?
Issue Number: ref #55722
Problem Summary:
What changed and how does it work?
Enable the DDL notifier by default.
I added the
DDLNotifierTableVersion
to init the DDL notifier table.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.