Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: Allow global Index including all columns in the partitioning expression #56868

Merged
merged 9 commits into from
Oct 30, 2024
Merged

ddl: Allow global Index including all columns in the partitioning expression #56868

merged 9 commits into from
Oct 30, 2024

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #56230

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Allow global Index including all columns in the partitioning expression.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 28, 2024
@tiprow tiprow
Copy link

tiprow bot commented Oct 28, 2024

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 57.4701%. Comparing base (7292117) to head (8b2a0f7).
Report is 40 commits behind head on master.

Additional details and impacted files 
@@                Coverage Diff                @@
##             master     #56868         +/-   ##
=================================================
- Coverage   73.2789%   57.4701%   -15.8089%     
=================================================
  Files          1636       1801        +165     
  Lines        453658     646276     +192618     
=================================================
+ Hits         332436     371416      +38980     
- Misses       100846     249478     +148632     
- Partials      20376      25382       +5006
Flag Coverage Δ
integration 39.5717% <87.5000%> (?)
unit 72.6696% <25.0000%> (+0.1816%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 63.1946% <ø> (+17.2148%) ⬆️

@Defined2014
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Oct 28, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mjonss
mjonss reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some minor questions

pkg/ddl/executor.go Outdated Show resolved Hide resolved
tests/integrationtest/r/globalindex/mem_index_lookup.result Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 29, 2024
Defined2014
Defined2014 commented Oct 29, 2024
View reviewed changes
pkg/ddl/executor.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjonss, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 30, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-29 10:52:03.63700333 +0000 UTC m=+347036.476158876: ☑️ agreed by mjonss.
  • 2024-10-30 06:04:32.311094105 +0000 UTC m=+416185.150249651: ☑️ agreed by tangenta.

@Defined2014
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Oct 30, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Defined2014
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Oct 30, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Defined2014
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Oct 30, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit fc116a7 into pingcap:master Oct 30, 2024
26 checks passed
@Defined2014 Defined2014 deleted the fix-56230 branch October 30, 2024 12:22
@Defined2014 Defined2014 mentioned this pull request Oct 31, 2024
Merged
13 tasks
@Defined2014 Defined2014 mentioned this pull request Nov 12, 2024
Open
16 tasks
@mjonss mjonss mentioned this pull request Nov 14, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@mjonss mjonss mjonss approved these changes

@lance6716 lance6716 Awaiting requested review from lance6716

@D3Hunter D3Hunter Awaiting requested review from D3Hunter

@GMHDBJD GMHDBJD Awaiting requested review from GMHDBJD

Assignees
No one assigned
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

global index limitation: Unsupported Global Index including all columns in the partitioning expression
3 participants
@Defined2014 @mjonss @tangenta