Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: record get owner TS and compare it before runReorgJob quit (#55049) #56909

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #55049

What problem does this PR solve?

Issue Number: close #54897

Problem Summary:

Timeline:

  1. tidb-0 run ingest backfill workers as the DDL owner.
  2. Inject network latency to tidb-0.
  3. tidb-1 get DDL owner, and switch to merge temp index step.
  4. Inject network latency to tidb-1. tidb-1's merge temp index backfill workers failed with "DDL is not owner"
  5. tidb-0 get DDL owner AGAIN, but reorgCtx is the one added in step(1).
  6. Merge temp index step is skipped because the reorgCtx is done.

What changed and how does it work?

Record get owner TS and compare it before runReorgJob quit.

Check List

Tests

  • Unit test
  • Integration test
    Here is the log from HA test:
    image
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. cherry-pick-approved Cherry pick PR approved by release team. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved labels Oct 28, 2024
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Oct 28, 2024
@ti-chi-bot ti-chi-bot bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 11, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 11, 2024
@joechenrh
Copy link
Contributor

/retest

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 52.38095% with 10 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.1@cc04dd7). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #56909   +/-   ##
================================================
  Coverage               ?   73.4744%           
================================================
  Files                  ?       1212           
  Lines                  ?     381360           
  Branches               ?          0           
================================================
  Hits                   ?     280202           
  Misses                 ?      83263           
  Partials               ?      17895           

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 11, 2024
Copy link

ti-chi-bot bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [tangenta,wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 12, 2024
Copy link

ti-chi-bot bot commented Nov 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-11 07:24:49.598277384 +0000 UTC m=+254651.789146380: ☑️ agreed by wjhuang2016.
  • 2024-11-12 02:35:11.81500847 +0000 UTC m=+323674.005877462: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit b47d473 into pingcap:release-7.1 Nov 12, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants