Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: cancel context when timer stop #56948

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Oct 29, 2024

What problem does this PR solve?

Issue Number: ref #53480

Problem Summary:
the context will leak because it is not cancelled.

What changed and how does it work?

cancel the context

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Oct 29, 2024
Copy link

tiprow bot commented Oct 29, 2024

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Leavrth Leavrth added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Oct 29, 2024
@3pointer 3pointer changed the title br: cancel context when timer stop [DNM] br: cancel context when timer stop Oct 29, 2024
@3pointer
Copy link
Contributor

/hold for adding test

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.3126%. Comparing base (3c8f2f3) to head (e1402b2).
Report is 40 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56948         +/-   ##
=================================================
- Coverage   73.3393%   57.3126%   -16.0268%     
=================================================
  Files          1636       1776        +140     
  Lines        453658     638857     +185199     
=================================================
+ Hits         332710     366146      +33436     
- Misses       100561     248125     +147564     
- Partials      20387      24586       +4199     
Flag Coverage Δ
integration 38.5954% <100.0000%> (?)
unit 72.8647% <100.0000%> (+0.3130%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 63.2931% <100.0000%> (+17.3164%) ⬆️

Signed-off-by: Jianjun Liao <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 30, 2024
@Leavrth Leavrth added needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 30, 2024
@Leavrth Leavrth changed the title [DNM] br: cancel context when timer stop br: cancel context when timer stop Oct 30, 2024
Signed-off-by: Jianjun Liao <[email protected]>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 30, 2024
Copy link

ti-chi-bot bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 30, 2024
Copy link

ti-chi-bot bot commented Oct 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-30 06:28:00.160674458 +0000 UTC m=+417592.999829989: ☑️ agreed by YuJuncen.
  • 2024-10-30 06:31:02.657305995 +0000 UTC m=+417775.496461542: ☑️ agreed by 3pointer.

Signed-off-by: Jianjun Liao <[email protected]>
@Leavrth
Copy link
Contributor Author

Leavrth commented Oct 30, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Oct 30, 2024
@Leavrth
Copy link
Contributor Author

Leavrth commented Oct 30, 2024

/retest

@Leavrth
Copy link
Contributor Author

Leavrth commented Oct 30, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Oct 30, 2024

@Leavrth: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test fast_test_tiprow_ddlargsv1
  • /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

  • fast_test_tiprow
  • tidb_parser_test

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 790c6c0 into pingcap:master Oct 30, 2024
28 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #57005.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 30, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #57006.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #57007.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 30, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #57008.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 30, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 30, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #57009.

ti-chi-bot bot pushed a commit that referenced this pull request Oct 30, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Oct 31, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Nov 4, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants