-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util/collate, util/ranger: move and update IsPadSpaceCollation()
#56970
util/collate, util/ranger: move and update IsPadSpaceCollation()
#56970
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: winoros, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #56970 +/- ##
=================================================
- Coverage 73.3059% 56.3328% -16.9731%
=================================================
Files 1638 1764 +126
Lines 453782 632684 +178902
=================================================
+ Hits 332649 356409 +23760
- Misses 100773 252252 +151479
- Partials 20360 24023 +3663
Flags with carried forward coverage won't be shown. Click here to find out more.
|
What problem does this PR solve?
Issue Number: N/A
Problem Summary:
Since
IsPadSpaceCollation
was introduced into the planner originally, two new PAD SPACE collations have been supported by tidb.Probably it's a proper time now to move this method to
util/collate
to be maintained by the SQL infra team.Note that although the checking is wrong in recent versions, there are no correctness issues. There is just some unnecessary accessing and filtering.
What changed and how does it work?
IsPadSpaceCollation()
for the newly introducedutf8mb4_0900_*
collations.IsPadSpaceCollation()
fromutil/ranger
toutil/collate
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.