Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: set min for high risk plan steps (#56631) #56973

Open
wants to merge 1 commit into
base: release-7.5
Choose a base branch
from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #56631

What problem does this PR solve?

Issue Number: close #55126

Problem Summary:

What changed and how does it work?

Ensure a minimum number of rows and a minimum row size for each plan operation for the optimizer cost model. And ensure that non-index based operations have a minimum of 1 row processed, and row length of at least 2. Index based operations can be fractional (less than 1) due to index probes being averaged out across all outer to inner probes for joins - thus the minimum of 1 row does not apply to index operations due to risk of biasing away from index joins or index merges.

Estimates at zero or below zero are possible in many situations due to realtime insert/update/delete tracking for statistics processing is not transactional (loss of statistics are OK - since it is not user data, and will be corrected next ANALYE). Below zero is rare but possible. In cardinality estimation, zero or near zero it possible due to assumption of independence with multiple predicates or multiple joins, and also with underestimation of any (or many) individual predicate(s).

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Oct 29, 2024
Copy link

ti-chi-bot bot commented Oct 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign buchuitoudegou for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Oct 29, 2024

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/build 74f89d8 link true /test build
idc-jenkins-ci-tidb/unit-test 74f89d8 link true /test unit-test
idc-jenkins-ci-tidb/check_dev_2 74f89d8 link true /test check-dev2
idc-jenkins-ci-tidb/check_dev 74f89d8 link true /test check-dev
idc-jenkins-ci-tidb/mysql-test 74f89d8 link true /test mysql-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants