-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: The length function could not be substitute when collation of mapped column is utfxxx_bin (#54179) #56994
planner: The length function could not be substitute when collation of mapped column is utfxxx_bin (#54179) #56994
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990, Rustin170506 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #56994 +/- ##
================================================
Coverage ? 73.4797%
================================================
Files ? 1212
Lines ? 381078
Branches ? 0
================================================
Hits ? 280015
Misses ? 83194
Partials ? 17869 |
This is an automated cherry-pick of #54179
What problem does this PR solve?
The constant propagated should consider the collation of mapped column.
For example,
The name = 'a' doesn't mean the all of column name data is 'a'. The 'a ' also can match the name='a' condition.
The reason is that 'utf8_bin' and 'utf8mb4_bin' are 'PAD SPACE' collation which means that it will ignore the trailing spaces.
**This kind of constant couldn't be propagated to 'Length' function. **
So I changed the columnSubstitute function to special due with 'length' function case.
Issue Number: close #53730
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.