Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: fix wrong error #57002

Merged
merged 1 commit into from
Oct 30, 2024
Merged

br: fix wrong error #57002

merged 1 commit into from
Oct 30, 2024

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Oct 30, 2024

What problem does this PR solve?

Issue Number: close #56999 ref #55870

Problem Summary:
annotate the wrong error

What changed and how does it work?

annotate the correct error

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Jianjun Liao <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Oct 30, 2024
Copy link

tiprow bot commented Oct 30, 2024

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Leavrth Leavrth added the needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. label Oct 30, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. and removed do-not-merge/needs-triage-completed labels Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.2795%. Comparing base (3c8f2f3) to head (17ab1c2).
Report is 40 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #57002         +/-   ##
=================================================
- Coverage   73.3393%   57.2795%   -16.0599%     
=================================================
  Files          1636       1776        +140     
  Lines        453658     639284     +185626     
=================================================
+ Hits         332710     366179      +33469     
- Misses       100561     248409     +147848     
- Partials      20387      24696       +4309     
Flag Coverage Δ
integration 38.3631% <0.0000%> (?)
unit 72.6808% <0.0000%> (+0.1291%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 63.2739% <0.0000%> (+17.2973%) ⬆️

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 30, 2024
Copy link

ti-chi-bot bot commented Oct 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-30 10:43:14.358618398 +0000 UTC m=+432907.197773944: ☑️ agreed by 3pointer.
  • 2024-10-30 10:53:28.2733009 +0000 UTC m=+433521.112456445: ☑️ agreed by BornChanger.

Copy link

ti-chi-bot bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Leavrth
Copy link
Contributor Author

Leavrth commented Oct 30, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Oct 30, 2024
@BornChanger
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 49c3eba into pingcap:master Oct 30, 2024
35 of 56 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #57010.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 30, 2024
13 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

br/stream: log status panics when encountering incompatible versions
5 participants