-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dxf: get task from both mysql.tidb_global_task
and mysql.tidb_global_task_history
#57063
Conversation
Hi @fzzf678. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #57063 +/- ##
=================================================
- Coverage 73.2123% 57.2797% -15.9327%
=================================================
Files 1652 1807 +155
Lines 456050 645111 +189061
=================================================
+ Hits 333885 369518 +35633
- Misses 101648 250314 +148666
- Partials 20517 25279 +4762
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CbcWestwolf, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
@fzzf678: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #56942
Problem Summary:
#56942 (comment)
What changed and how does it work?
Get the task from
mysql.tidb_global_task
andmysql.tidb_global_task_history
inupdateDistTaskRowCount
, and sum up the row count from bothtidb_background_subtask
andtidb_background_subtask_history
table.Check List
Tests
100
tables with10000
rows each.row_count
should all be10000
:Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.