Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dxf: get task from both mysql.tidb_global_task and mysql.tidb_global_task_history #57063

Merged
merged 7 commits into from
Nov 5, 2024

Conversation

fzzf678
Copy link
Contributor

@fzzf678 fzzf678 commented Nov 1, 2024

What problem does this PR solve?

Issue Number: close #56942

Problem Summary:
#56942 (comment)

What changed and how does it work?

Get the task from mysql.tidb_global_task and mysql.tidb_global_task_history in updateDistTaskRowCount, and sum up the row count from both tidb_background_subtask and tidb_background_subtask_history table.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. Use sysbench create 100 tables with 10000 rows each.
  2. After all ddl jobs finished, check the ddl job row count, the row_count should all be 10000:
mysql> admin show ddl jobs 100 where row_count != 10000;
Empty set (0.03 sec)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 1, 2024
Copy link

tiprow bot commented Nov 1, 2024

Hi @fzzf678. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.2797%. Comparing base (5448f9f) to head (9dcd906).
Report is 14 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #57063         +/-   ##
=================================================
- Coverage   73.2123%   57.2797%   -15.9327%     
=================================================
  Files          1652       1807        +155     
  Lines        456050     645111     +189061     
=================================================
+ Hits         333885     369518      +35633     
- Misses       101648     250314     +148666     
- Partials      20517      25279       +4762     
Flag Coverage Δ
integration 39.5491% <100.0000%> (?)
unit 72.6107% <100.0000%> (+0.1189%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 62.8075% <ø> (+16.8259%) ⬆️

@fzzf678 fzzf678 requested a review from tangenta November 4, 2024 02:50
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 4, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 4, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 4, 2024
Copy link

ti-chi-bot bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 5, 2024
Copy link

ti-chi-bot bot commented Nov 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-04 09:51:32.731986074 +0000 UTC m=+861805.571141619: ☑️ agreed by tangenta.
  • 2024-11-05 02:12:13.886186896 +0000 UTC m=+920646.725342442: ☑️ agreed by CbcWestwolf.

@fzzf678
Copy link
Contributor Author

fzzf678 commented Nov 5, 2024

/retest

Copy link

tiprow bot commented Nov 5, 2024

@fzzf678: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 7e491c3 into pingcap:master Nov 5, 2024
26 checks passed
@tangenta tangenta added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 5, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #57125.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Row count maybe inaccurate when adding index with DXF
4 participants