Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix the flaky test TestDeleteIgnoreWithFK #57095

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Nov 4, 2024

What problem does this PR solve?

Issue Number: close #57094

Problem Summary:

The test TestDeleteIgnoreWithFK is flaky because of the order of warnings.

What changed and how does it work?

Sort the warnings before the assertion.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 4, 2024
@YangKeao YangKeao added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 4, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 4, 2024
Copy link

ti-chi-bot bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 4, 2024
Copy link

ti-chi-bot bot commented Nov 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-04 05:57:48.260641555 +0000 UTC m=+847781.099797096: ☑️ agreed by Defined2014.
  • 2024-11-04 05:58:54.269927876 +0000 UTC m=+847847.109083418: ☑️ agreed by hawkingrei.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.4479%. Comparing base (390de88) to head (c803724).
Report is 31 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #57095         +/-   ##
=================================================
- Coverage   73.2941%   56.4479%   -16.8462%     
=================================================
  Files          1638       1778        +140     
  Lines        453785     638618     +184833     
=================================================
+ Hits         332598     360487      +27889     
- Misses       100814     253869     +153055     
- Partials      20373      24262       +3889     
Flag Coverage Δ
integration 37.0606% <ø> (?)
unit 72.5099% <ø> (+0.0045%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.5722% <ø> (+6.5733%) ⬆️

@ti-chi-bot ti-chi-bot bot merged commit 572cf9e into pingcap:master Nov 4, 2024
23 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #57097.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestDeleteIgnoreWithFK is flaky
4 participants