-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix the flaky test TestDeleteIgnoreWithFK
#57095
Conversation
Signed-off-by: Yang Keao <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #57095 +/- ##
=================================================
- Coverage 73.2941% 56.4479% -16.8462%
=================================================
Files 1638 1778 +140
Lines 453785 638618 +184833
=================================================
+ Hits 332598 360487 +27889
- Misses 100814 253869 +153055
- Partials 20373 24262 +3889
Flags with carried forward coverage won't be shown. Click here to find out more.
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #57094
Problem Summary:
The test
TestDeleteIgnoreWithFK
is flaky because of the order of warnings.What changed and how does it work?
Sort the warnings before the assertion.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.