Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dumpling: make metadata collection failure a warning #57202

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Nov 7, 2024

What problem does this PR solve?

Issue Number: ref #53082

Problem Summary:

Related to: #53082 (comment)

I think failure to collect metadata should be at least a warning instead of an info message.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. component/dumpling This is related to Dumpling of TiDB. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 7, 2024
Copy link

tiprow bot commented Nov 7, 2024

Hi @dveeden. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dveeden dveeden mentioned this pull request Nov 7, 2024
3 tasks
@dveeden
Copy link
Contributor Author

dveeden commented Nov 7, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Nov 7, 2024
@dveeden
Copy link
Contributor Author

dveeden commented Nov 7, 2024

/retest

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.2085%. Comparing base (fda9d39) to head (24ae46b).
Report is 6 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #57202         +/-   ##
=================================================
- Coverage   73.0753%   56.2085%   -16.8669%     
=================================================
  Files          1659       1785        +126     
  Lines        458027     637647     +179620     
=================================================
+ Hits         334705     358412      +23707     
- Misses       102796     254996     +152200     
- Partials      20526      24239       +3713     
Flag Coverage Δ
integration 36.9643% <ø> (?)
unit 72.2910% <0.0000%> (-0.0641%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <0.0000%> (ø)
parser ∅ <ø> (∅)
br 51.1585% <ø> (+5.4604%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 7, 2024
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 7, 2024
Copy link

ti-chi-bot bot commented Nov 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-07 09:08:19.003723027 +0000 UTC m=+1118411.842878566: ☑️ agreed by lance6716.
  • 2024-11-07 09:54:31.99208715 +0000 UTC m=+1121184.831242692: ☑️ agreed by GMHDBJD.

@ti-chi-bot ti-chi-bot bot merged commit d1652cf into pingcap:master Nov 7, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component/dumpling This is related to Dumpling of TiDB. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants