Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txn: bump checksum version (#57205) #57220

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57205

What problem does this PR solve?

Issue Number: close #57206

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.
deploy tidb cluster v8.3.0

create table t(a int primary key, b int);
insert into t values (1, 2);

upgrade tidb to v8.4.0

update t set b = 3 where a = 1;

update t set a = 2 where a = 1;

output:


[2024/11/07 18:50:10.138 +08:00] [INFO] [mounter.go:636] ["raw bytes checksum matched"] [version=1] [expected=1383743328] [obtained=1383743328]

[2024/11/07 18:55:49.438 +08:00] [INFO] [mounter.go:636] ["raw bytes checksum matched"] [version=1] [expected=1383743328] [obtained=1383743328]
[2024/11/07 18:55:49.438 +08:00] [INFO] [mounter.go:636] ["raw bytes checksum matched"] [version=2] [expected=3631181330] [obtained=3631181330]

[2024/11/07 18:56:07.438 +08:00] [INFO] [mounter.go:636] ["raw bytes checksum matched"] [version=2] [expected=3631181330] [obtained=3631181330]
[2024/11/07 18:56:07.438 +08:00] [INFO] [mounter.go:636] ["raw bytes checksum matched"] [version=2] [expected=1097220008] [obtained=1097220008]

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 7, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 7, 2024
13 tasks
Copy link

ti-chi-bot bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lance6716 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Nov 7, 2024

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test-ddlv1 cdbdfe1 link true /test pull-unit-test-ddlv1
idc-jenkins-ci-tidb/unit-test cdbdfe1 link true /test unit-test
idc-jenkins-ci-tidb/build cdbdfe1 link true /test build
idc-jenkins-ci-tidb/check_dev_2 cdbdfe1 link true /test check-dev2
idc-jenkins-ci-tidb/check_dev cdbdfe1 link true /test check-dev
idc-jenkins-ci-tidb/mysql-test cdbdfe1 link true /test mysql-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Nov 8, 2024
@3AceShowHand
Copy link
Contributor

merged by the #57186, close this

@ti-chi-bot ti-chi-bot bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Nov 14, 2024
Copy link

ti-chi-bot bot commented Nov 14, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants