store: make storage type a enum

[D3Hunter]

What problem does this PR solve?

Issue Number: ref #57275

Problem Summary:

What changed and how does it work?

as title

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 86.84211% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.9849%. Comparing base (6528da5) to head (5da76ad).
Report is 3 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #57276        +/-   ##
================================================
+ Coverage   72.9071%   74.9849%   +2.0778%     
================================================
  Files          1667       1714        +47     
  Lines        460833     469778      +8945     
================================================
+ Hits         335980     352263     +16283     
+ Misses       104199      95587      -8612     
- Partials      20654      21928      +1274     

Flag	Coverage Δ
integration	49.2389% <54.0540%> (?)
unit	72.5577% <76.3157%> (+0.2622%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.7673% <100.0000%> (ø)
parser	∅ <ø> (∅)
br	60.6530% <100.0000%> (+15.5792%)	⬆️

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-11-11 05:54:49.706006577 +0000 UTC m=+249251.896875568: ☑️ agreed by lance6716.
• 2024-11-11 07:03:09.878881764 +0000 UTC m=+253352.069750761: ☑️ agreed by lcwangchao.

[tiprow]

@D3Hunter: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
fast_test_tiprow	0e2534a	link	true	/test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[D3Hunter]

/test check-dev2
/test pull-lightning-integration-test

[tiprow]

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2
/test pull-lightning-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[D3Hunter]

/test check-dev2

[tiprow]

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[D3Hunter]

wait #57298 fixed

[yudongusa]

Please provide more detailed description of the issue.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, lance6716, lcwangchao, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [3pointer,lance6716,lcwangchao]
• br/OWNERS [3pointer]
• dumpling/OWNERS [lance6716]
• pkg/config/OWNERS [yudongusa]
• pkg/ddl/OWNERS [lance6716]
• pkg/disttask/OWNERS [lance6716]
• pkg/sessionctx/variable/OWNERS [yudongusa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[D3Hunter]

/retest

[tiprow]

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.