ddl: add COMMENTS column to DDL jobs and enhance job reorg meta handling

[tangenta]

What problem does this PR solve?

Issue Number: ref #57229

Problem Summary: See #57229

What changed and how does it work?

• Add COMMENTS column to ADMIN SHOW DDL JOBS.
• Refine DDL job reorg meta initialization. For example, let "modify column"/"reorg partition" and other reorg DDL types utilize ReorgMeta.Concurrency and ReorgMeta.BatchSize.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tangenta and additionally assign rustin170506 for approval(Please ensuring that each of them provides their approval before proceeding). For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS
• pkg/ddl/OWNERS
• pkg/meta/OWNERS
• pkg/planner/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tiprow]

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 51.92308% with 75 lines in your changes missing coverage. Please review.

Project coverage is 74.7831%. Comparing base (aeed37b) to head (15feec8).
Report is 23 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #57392        +/-   ##
================================================
+ Coverage   72.8693%   74.7831%   +1.9137%     
================================================
  Files          1672       1717        +45     
  Lines        461965     476145     +14180     
================================================
+ Hits         336631     356076     +19445     
+ Misses       104569      97919      -6650     
- Partials      20765      22150      +1385     

Flag	Coverage Δ
integration	48.9953% <51.9230%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.7673% <ø> (ø)
parser	∅ <ø> (∅)
br	59.5577% <ø> (+14.4290%)	⬆️

[ti-chi-bot]

@tangenta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
idc-jenkins-ci-tidb/check_dev_2	15feec8	link	true	/test check-dev2
pull-br-integration-test	15feec8	link	true	/test pull-br-integration-test
idc-jenkins-ci-tidb/unit-test	15feec8	link	true	/test unit-test
pull-unit-test-ddlv1	15feec8	link	true	/test pull-unit-test-ddlv1

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.