ttl: cancel the hearbeat timeout job after disable the TTL #57452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57452 +/- ##
================================================
+ Coverage 72.8400% 73.6332% +0.7931%
================================================
Files 1672 1672
Lines 462663 463796 +1133
================================================
+ Hits 337004 341508 +4504
+ Misses 104862 101525 -3337
+ Partials 20797 20763 -34
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Yang Keao <[email protected]>
lcwangchao
approved these changes
Nov 18, 2024
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
Defined2014
approved these changes
Nov 18, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, lcwangchao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #57404
Problem Summary:
If a job's hearbeat timeout, it cannot be cancelled after disabling the TTL job.
What changed and how does it work?
Move the logic of locking the heartbeat timeout job above the logic of cancelling jobs.
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.