parser: Add mode into UnReservedKeyword list #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"mode" can be used as an identifier. See: https://dev.mysql.com/doc/refman/5.7/en/keywords.html
|
LGTM |
1 similar comment
|
LGTM |
ngaut
added a commit
that referenced
this pull request
Sep 8, 2015
parser: Add mode into UnReservedKeyword list
|
Thanks! |
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
…ng (pingcap#61) * vendor: insert `go-semver` dependecy * tidb, util: extract the HTTP JSON fetching code into its own function * *: check for cluster versions before starting * restore_test: added logs to detect spurious failure Also, make the mock import operation only wait while we're still opening engines to speed up the test. * util: document GetJSON() * restore: use a more robust version parsing strategy for TiDB In semver, '2.0.4-1 < 2.0.4', so we need to properly skip the unrelated portions of the version. * restore, kv: detect if SwitchMode exists instead of check version TiKV and PD's versions are exposed before 2.1, so we can't rely on their APIs to verify for 2.0.4+. Since the only reason we need 2.0.4+ is the SwitchMode gRPC interface, we instead inspect if SwitchMode is unimplemented and display a user-friendly message on stderr.
iosmanthus
pushed a commit
to iosmanthus/tidb
that referenced
this pull request
Oct 31, 2022
Signed-off-by: disksing <[email protected]> Signed-off-by: disksing <[email protected]>
mittalrishabh
pushed a commit
to mittalrishabh/tidb
that referenced
this pull request
May 6, 2024
…#51371) (pingcap#46) (pingcap#61) close pingcap#51370 Co-authored-by: 山岚 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"mode" can be used as an identifier.
See: https://dev.mysql.com/doc/refman/5.7/en/keywords.html
@unknwon The following bug is caused by parser. This pr will fix it.
SELECT id, user_id, repo_id, mode FROM access WHERE repo_id=? AND mode>=?
, error: line 1 column 77 near "mode"
Is > a invalid operator?