-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CONTRIBUTING.md #6965
Update CONTRIBUTING.md #6965
Conversation
fix `ERROR 1105 (HY000): Unknown charset id 255` in mysql client 8's arguments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lilin90 PTAL
CONTRIBUTING.md
Outdated
@@ -194,6 +194,12 @@ Then you can connect to TiDB with mysql client. | |||
mysql -h127.0.0.1 -P4000 -uroot test | |||
``` | |||
|
|||
If you use mysql client 8, you must be get error `ERROR 1105 (HY000): Unknown charset id 255`, you can add `--default-character-set utf8` in mysql client 8's arguments. [Issue #6942](https://github.com/pingcap/tidb/issues/6942) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/you must be get error/you may get the error/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I fixed.
CONTRIBUTING.md
Outdated
@@ -194,6 +194,12 @@ Then you can connect to TiDB with mysql client. | |||
mysql -h127.0.0.1 -P4000 -uroot test | |||
``` | |||
|
|||
If you use mysql client 8, you may get the error `ERROR 1105 (HY000): Unknown charset id 255`, you can add `--default-character-set utf8` in mysql client 8's arguments. [Issue #6942](https://github.com/pingcap/tidb/issues/6942) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please modify the first sentence to:
If you use MySQL client 8, you may get the ERROR 1105 (HY000): Unknown charset id 255
error. To solve it, you can add --default-character-set utf8
in MySQL client 8's arguments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What have you changed? (mandatory)
fix
ERROR 1105 (HY000): Unknown charset id 255
in mysql client 8's arguments.mysql -h127.0.0.1 -P4000 -uroot test --default-character-set utf8
What are the type of the changes (mandatory)?
#6942
How has this PR been tested (mandatory)?
Directly execute SQL.