Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #6965

Merged
merged 7 commits into from
Jul 4, 2018
Merged

Update CONTRIBUTING.md #6965

merged 7 commits into from
Jul 4, 2018

Conversation

yangwenmai
Copy link
Contributor

What have you changed? (mandatory)

fix ERROR 1105 (HY000): Unknown charset id 255 in mysql client 8's arguments.

mysql -h127.0.0.1 -P4000 -uroot test --default-character-set utf8

What are the type of the changes (mandatory)?

#6942

How has this PR been tested (mandatory)?

Directly execute SQL.

fix `ERROR 1105 (HY000): Unknown charset id 255` in mysql client 8's arguments.
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@shenli shenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lilin90 PTAL

CONTRIBUTING.md Outdated
@@ -194,6 +194,12 @@ Then you can connect to TiDB with mysql client.
mysql -h127.0.0.1 -P4000 -uroot test
```

If you use mysql client 8, you must be get error `ERROR 1105 (HY000): Unknown charset id 255`, you can add `--default-character-set utf8` in mysql client 8's arguments. [Issue #6942](https://github.com/pingcap/tidb/issues/6942)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/you must be get error/you may get the error/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I fixed.

CONTRIBUTING.md Outdated
@@ -194,6 +194,12 @@ Then you can connect to TiDB with mysql client.
mysql -h127.0.0.1 -P4000 -uroot test
```

If you use mysql client 8, you may get the error `ERROR 1105 (HY000): Unknown charset id 255`, you can add `--default-character-set utf8` in mysql client 8's arguments. [Issue #6942](https://github.com/pingcap/tidb/issues/6942)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify the first sentence to:

If you use MySQL client 8, you may get the ERROR 1105 (HY000): Unknown charset id 255 error. To solve it, you can add --default-character-set utf8 in MySQL client 8's arguments.

@zz-jason zz-jason added type/enhancement The issue or PR belongs to an enhancement. status/LGT1 Indicates that a PR has LGTM 1. component/docs contribution This PR is from a community contributor. labels Jul 3, 2018
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winoros winoros merged commit 9d49f83 into pingcap:master Jul 4, 2018
@yangwenmai yangwenmai deleted the patch-1 branch July 4, 2018 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/docs contribution This PR is from a community contributor. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants