executor: support MAX/MIN in new evaluation framework partially #6971
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,191 @@ | ||
| // Copyright 2018 PingCAP, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package aggfuncs | ||
|
|
||
| import ( | ||
| "github.com/juju/errors" | ||
| "github.com/pingcap/tidb/sessionctx" | ||
| "github.com/pingcap/tidb/types" | ||
| "github.com/pingcap/tidb/util/chunk" | ||
| ) | ||
|
|
||
| type partialResult4MaxMinInt int64 | ||
| type partialResult4MaxMinDecimal *types.MyDecimal | ||
| type partialResult4MaxMinFloat32 float32 | ||
| type partialResult4MaxMinFloat64 float64 | ||
|
|
||
| // Todo | ||
| type partialResult4MaxMinString string | ||
| type partialResult4MaxMinDatetime types.Time | ||
| type partialResult4MaxMinTimestamp types.Time | ||
| type partialResult4MaxMinDuration types.Duration | ||
|
|
||
| type maxMin4Int struct { | ||
| baseAggFunc | ||
|
|
||
| isMax bool | ||
| isUnsigned bool | ||
| } | ||
|
|
||
| func (e *maxMin4Int) AllocPartialResult() PartialResult { | ||
| return PartialResult(new(partialResult4MaxMinInt)) | ||
| } | ||
|
|
||
| func (e *maxMin4Int) ResetPartialResult(pr PartialResult) { | ||
| *(*partialResult4MaxMinInt)(pr) = 0 | ||
| } | ||
|
|
||
| func (e *maxMin4Int) AppendFinalResult2Chunk(sctx sessionctx.Context, pr PartialResult, chk *chunk.Chunk) error { | ||
| if !e.isUnsigned { | ||
| chk.AppendInt64(e.ordinal, int64(*(*partialResult4MaxMinInt)(pr))) | ||
| } else { | ||
| chk.AppendUint64(e.ordinal, uint64(*(*partialResult4MaxMinInt)(pr))) | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func (e *maxMin4Int) UpdatePartialResult(sctx sessionctx.Context, rowsInGroup []chunk.Row, pr PartialResult) error { | ||
| tmp := (*partialResult4MaxMinInt)(pr) | ||
|
There was a problem hiding this comment. to keep consistent with |
||
| for _, row := range rowsInGroup { | ||
| input, isNull, err := e.args[0].EvalInt(sctx, row) | ||
| if err != nil { | ||
| return errors.Trace(err) | ||
| } | ||
| if isNull { | ||
| continue | ||
| } | ||
| if !e.isUnsigned { | ||
|
There was a problem hiding this comment. put this |
||
| if f0, f1 := int64(*tmp), int64(input); e.isMax && f1 > f0 || !e.isMax && f1 < f0 { | ||
|
|
||
| *tmp = partialResult4MaxMinInt(f1) | ||
| } | ||
| } else { | ||
| if f0, f1 := uint64(*tmp), uint64(input); e.isMax && f1 > f0 || !e.isMax && f1 < f0 { | ||
| *tmp = partialResult4MaxMinInt(f1) | ||
| } | ||
| } | ||
|
There was a problem hiding this comment. uint64Input := uint64(input)
if !e.executed {
*p = uint64Input
e.executed = true
continue
}
if e.isMax && uint64Input > *p || !e.isMax && uint64Input < *p {
*p = uint64Input
} |
||
| } | ||
| return nil | ||
| } | ||
|
|
||
| // maxMin4Float32 gets a float32 input and returns a float32 result. | ||
| type maxMin4Float32 struct { | ||
| baseAggFunc | ||
|
|
||
| isMax bool | ||
| } | ||
|
|
||
| func (e *maxMin4Float32) AllocPartialResult() PartialResult { | ||
| return PartialResult(new(partialResult4MaxMinFloat32)) | ||
| } | ||
|
|
||
| func (e *maxMin4Float32) ResetPartialResult(pr PartialResult) { | ||
| *(*partialResult4MaxMinFloat32)(pr) = 0 | ||
| } | ||
|
|
||
| func (e *maxMin4Float32) AppendFinalResult2Chunk(sctx sessionctx.Context, pr PartialResult, chk *chunk.Chunk) error { | ||
| chk.AppendFloat32(e.ordinal, float32(*(*partialResult4MaxMinFloat32)(pr))) | ||
|
There was a problem hiding this comment. chk.AppendFloat32(e.ordinal, *(*partialResult4MaxMinFloat32)(pr)) |
||
| return nil | ||
| } | ||
|
|
||
| func (e *maxMin4Float32) UpdatePartialResult(sctx sessionctx.Context, rowsInGroup []chunk.Row, pr PartialResult) error { | ||
| tmp := (*partialResult4MaxMinFloat32)(pr) | ||
| for _, row := range rowsInGroup { | ||
| input, isNull, err := e.args[0].EvalReal(sctx, row) | ||
| if err != nil { | ||
| return errors.Trace(err) | ||
| } | ||
| if isNull { | ||
| continue | ||
| } | ||
| if f0, f1 := float32(*tmp), float32(input); e.isMax && f1 > f0 || !e.isMax && f1 < f0 { | ||
| *tmp = partialResult4MaxMinFloat32(f1) | ||
| } | ||
|
There was a problem hiding this comment. float32Input := float32(input)
if !e.executed {
*p = float32Input
e.executed = true
continue
}
if e.isMax && float32Input > *p || !e.isMax && float32Input < *p {
*p = float32Input
} |
||
| } | ||
| return nil | ||
| } | ||
|
|
||
| type maxMin4Float64 struct { | ||
| baseAggFunc | ||
|
|
||
| isMax bool | ||
| } | ||
|
|
||
| func (e *maxMin4Float64) AllocPartialResult() PartialResult { | ||
| return PartialResult(new(partialResult4MaxMinFloat64)) | ||
| } | ||
|
|
||
| func (e *maxMin4Float64) ResetPartialResult(pr PartialResult) { | ||
| *(*partialResult4MaxMinFloat64)(pr) = 0 | ||
| } | ||
|
|
||
| func (e *maxMin4Float64) AppendFinalResult2Chunk(sctx sessionctx.Context, pr PartialResult, chk *chunk.Chunk) error { | ||
| chk.AppendFloat64(e.ordinal, float64(*(*partialResult4MaxMinFloat64)(pr))) | ||
|
There was a problem hiding this comment. chk.AppendFloat64(e.ordinal, *(*partialResult4MaxMinFloat64)(pr)) |
||
| return nil | ||
| } | ||
|
|
||
| func (e *maxMin4Float64) UpdatePartialResult(sctx sessionctx.Context, rowsInGroup []chunk.Row, pr PartialResult) error { | ||
| tmp := (*partialResult4MaxMinFloat64)(pr) | ||
| for _, row := range rowsInGroup { | ||
| input, isNull, err := e.args[0].EvalReal(sctx, row) | ||
| if err != nil { | ||
| return errors.Trace(err) | ||
| } | ||
| if isNull { | ||
| continue | ||
| } | ||
| if f0, f1 := float64(*tmp), float64(input); e.isMax && f1 > f0 || !e.isMax && f1 < f0 { | ||
| *tmp = partialResult4MaxMinFloat64(f1) | ||
| } | ||
|
There was a problem hiding this comment. if e.isMax && input > *p || !e.isMax && input < *p {
*p = input
} |
||
| } | ||
| return nil | ||
| } | ||
|
|
||
| type maxMin4Decimal struct { | ||
| baseAggFunc | ||
|
|
||
| isMax bool | ||
| } | ||
|
|
||
| func (e *maxMin4Decimal) AllocPartialResult() PartialResult { | ||
| return PartialResult(new(partialResult4MaxMinDecimal)) | ||
| } | ||
|
|
||
| func (e *maxMin4Decimal) ResetPartialResult(pr PartialResult) { | ||
| *(*partialResult4MaxMinDecimal)(pr) = partialResult4MaxMinDecimal(*new(partialResult4MaxMinDecimal)) | ||
| } | ||
|
|
||
| func (e *maxMin4Decimal) AppendFinalResult2Chunk(sctx sessionctx.Context, pr PartialResult, chk *chunk.Chunk) error { | ||
| chk.AppendMyDecimal(e.ordinal, (*types.MyDecimal)(*(*partialResult4MaxMinDecimal)(pr))) | ||
|
There was a problem hiding this comment. chk.AppendMyDecimal(e.ordinal, *(*partialResult4MaxMinDecimal)(pr)) |
||
| return nil | ||
| } | ||
|
|
||
| func (e *maxMin4Decimal) UpdatePartialResult(sctx sessionctx.Context, rowsInGroup []chunk.Row, pr PartialResult) error { | ||
| tmp := (*partialResult4MaxMinDecimal)(pr) | ||
| for _, row := range rowsInGroup { | ||
| input, isNull, err := e.args[0].EvalDecimal(sctx, row) | ||
| if err != nil { | ||
| return errors.Trace(err) | ||
| } | ||
| if isNull { | ||
| continue | ||
| } | ||
| f0, f1 := (*types.MyDecimal)(*tmp), (*types.MyDecimal)(input) | ||
| cmp := f1.Compare(f0) | ||
| if e.isMax && cmp == 1 || !e.isMax && cmp == -1 { | ||
| *tmp = partialResult4MaxMinDecimal(f1) | ||
| } | ||
|
There was a problem hiding this comment. cmp := input.Compare(*p)
if e.isMax && cmp == 1 || !e.isMax && cmp == -1 {
*p = input
} |
||
| } | ||
| return nil | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How aboult use
type partialResult4MaxMinInt = int64,then we can use
*(*partialResult4MaxMinInt)(pr)instead ofint64(*(*partialResult4MaxMinInt)(pr))below partialResult4MaxMinDecimal, partialResult4MaxMinFloat32, partialResult4MaxMinFloat64 is same too.
here is a benchmark