-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
model: implement UnmarshalJSON for CIStr #7252
Conversation
So it can be unmarshaled from a single string
model/model.go
Outdated
return nil | ||
} | ||
|
||
// Unmarshal CIStr from a single string. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some comment, explain why we need to unmarshal from a single string.
/run-all-tests |
LGTM |
95ddd18
to
75aada2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
What have you changed? (mandatory)
So it can be unmarshaled from a single string
What is the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
unit test
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
no
Does this PR affect tidb-ansible update? (mandatory)
no
Does this PR need to be added to the release notes? (mandatory)
no
Refer to a related PR or issue link (optional)
no
Benchmark result if necessary (optional)
I'll add one
Add a few positive/negative examples (optional)
Upgrade from 2.0 to master may meets some problems if partition tables are used.
Because master use
while 2.0 use
After this PR, the upgrade would be smooth.
@winkyao @ciscoxll @shenli