Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: collect execution details and output them in slow query log #7364

Merged
merged 1 commit into from
Aug 13, 2018

Conversation

coocood
Copy link
Member

@coocood coocood commented Aug 13, 2018

Cherry-pick #7302

What problem does this PR solve?

Makes it easier to find the culprit slow query that makes the cluster slow.

What is changed and how it works?

Records every coprocessor execution details and merge them into StmtContext.
Output the merged details in slow-query log.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change

Related changes

  • Need to update the documentation
  • Need to be included in the release note

@coocood
Copy link
Member Author

coocood commented Aug 13, 2018

@tiancaiamao @zz-jason PTAL

@tiancaiamao
Copy link
Contributor

LGTM

Copy link
Contributor

@zhexuany zhexuany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood
Copy link
Member Author

coocood commented Aug 13, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0

@coocood coocood added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 13, 2018
@coocood coocood merged commit 23b6f05 into pingcap:release-2.0 Aug 13, 2018
@coocood coocood deleted the collect-details-2.0 branch August 13, 2018 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants