Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: handle max_allowed_packet warnings for repeat function. c… #7431

Merged
merged 2 commits into from
Aug 22, 2018
Merged

expression: handle max_allowed_packet warnings for repeat function. c… #7431

merged 2 commits into from
Aug 22, 2018

Conversation

hhu-cc
Copy link
Contributor

@hhu-cc hhu-cc commented Aug 19, 2018 •
edited
Loading

What problem does this PR solve?

cherrypick #7181 (from commit 2fbd5e7) to release-2.0

What is changed and how it works?

Return NULL when the result of function REPEAT is larger than max_allowed_packet

Check List

Tests

  • Unit test

Related changes

  • Need to be included in the release note
Return `NULL` when the result of function `REPEAT` is larger than `max_allowed_packet`

@sre-bot
Copy link
Contributor

sre-bot commented Aug 19, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@zz-jason
Copy link
Member

LGTM

@zz-jason zz-jason added contribution This PR is from a community contributor. type/bugfix This PR fixes a bug. component/expression type/2.0 cherry-pick status/LGT1 Indicates that a PR has LGTM 1. labels Aug 20, 2018
@zz-jason
Copy link
Member

@XuHuaiyu PTAL

@XuHuaiyu
Copy link
Contributor

/run-all-tests tikv=release-2.0 pd=release-2.0 tidb-test=release-2.0

XuHuaiyu
XuHuaiyu approved these changes Aug 21, 2018
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 21, 2018
@ngaut ngaut merged commit fc14119 into pingcap:release-2.0 Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hhu-cc @sre-bot @zz-jason @XuHuaiyu @ngaut @zimulala