Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl, metrics: add job action and schema version information to metrics #7472

Merged
merged 2 commits into from
Aug 27, 2018

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Aug 23, 2018

What problem does this PR solve?

Add job action and schema version information to metrics.
Remove "DDLJobErrCounter"(We didn't use it before in grafana) and add error count information to "DDLWorkerHistogram".

What is changed and how it works?

Add two labels.

Check List

Tests

  • No code

Related changes

@zimulala
Copy link
Contributor Author

/run-all-tests

@zimulala
Copy link
Contributor Author

PTAL @winkyao @shenli @ciscoxll @crazycs520

@zimulala
Copy link
Contributor Author

/run-unit-test


// Metrics for ddl_worker.go.
WorkerAddDDLJob = "add_job"
WorkerRunDDLJob = "run_job"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also feel the label is not enough, so I also add a label.

Copy link
Contributor

@ciscoxll ciscoxll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 24, 2018
@zimulala
Copy link
Contributor Author

PTAL @winkyao @shenli @crazycs520

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520 crazycs520 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 27, 2018
@zimulala zimulala merged commit 3af92ab into pingcap:master Aug 27, 2018
@zimulala zimulala deleted the metrics branch August 27, 2018 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/metrics status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants