Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: batch check the constrains when we add a unique-index. (#7132) #7562

Merged
merged 2 commits into from
Sep 6, 2018
Merged

ddl: batch check the constrains when we add a unique-index. (#7132) #7562

merged 2 commits into from
Sep 6, 2018

Conversation

winkyao
Copy link
Contributor

@winkyao winkyao commented Aug 31, 2018

What problem does this PR solve?

This is a cherry-pick from #7132

jackysp
jackysp reviewed Aug 31, 2018
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ciscoxll
Copy link
Contributor

/run-all-tests

@jackysp
Copy link
Member

jackysp commented Aug 31, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

zimulala
zimulala reviewed Sep 3, 2018
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 3, 2018
alivxxx
alivxxx approved these changes Sep 5, 2018
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Sep 5, 2018
@winkyao winkyao merged commit d0a8faa into pingcap:release-2.0 Sep 6, 2018
@winkyao winkyao deleted the cherry-pick-2.0 branch September 6, 2018 07:46
@winkyao winkyao added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 6, 2018
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@jackysp jackysp jackysp left review comments

@alivxxx alivxxx alivxxx approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/sql-infra SIG: SQL Infra status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@winkyao @ciscoxll @jackysp @zimulala @alivxxx @shenli @you06