Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: fix single line comment end with newline error #7612

Merged
merged 1 commit into from
Sep 5, 2018
Merged

parser: fix single line comment end with newline error #7612

merged 1 commit into from
Sep 5, 2018

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Sep 4, 2018 •
edited
Loading

What problem does this PR solve?

fixes #7603

What is changed and how it works?

support single line comment end with newline and \t, also EOF

Check List

Tests

  • Unit test

Code changes

  • impl

Side effects

  • no

Related changes

  • Need to cherry-pick to the release branch(need confirm)
  • Need to be included in the release note

This change is Reviewable

@lysu lysu changed the title parser: fix single line comment end with newline parser: fix single line comment end with newline error Sep 4, 2018
@shenli
Copy link
Member

shenli commented Sep 4, 2018

@lysu Please fix the CI.

@lysu
Copy link
Contributor Author

lysu commented Sep 4, 2018

/run-all-tests

zz-jason
zz-jason reviewed Sep 5, 2018
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 5, 2018
ngaut
ngaut approved these changes Sep 5, 2018
View reviewed changes
Copy link
Member

@ngaut ngaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngaut ngaut merged commit a18d27e into pingcap:master Sep 5, 2018
@lysu lysu deleted the dev-fix-single-line-comment branch September 5, 2018 02:48
@lysu lysu mentioned this pull request Sep 6, 2018
Merged
zz-jason pushed a commit that referenced this pull request Sep 7, 2018
@lysu @zz-jason
parser: fix single line comment end with newline (#7612) (#7635)
c4417f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@ngaut ngaut ngaut approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
component/parser status/LGT1 Indicates that a PR has LGTM 1. type/compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parser failed to parse comment starts with two dash without whitespace but follows by other control character
4 participants
@lysu @shenli @ngaut @zz-jason