Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: json builtin function archetypes #7651

Merged
merged 5 commits into from
Sep 10, 2018

Conversation

mccxj
Copy link
Contributor

@mccxj mccxj commented Sep 9, 2018

What problem does this PR solve?

#7546

What is changed and how it works?

like https://pingcap.com/blog-cn/add-a-built-in-function/, add json builtin function archetypes.

@mccxj
Copy link
Contributor Author

mccxj commented Sep 9, 2018

@shenli @zz-jason PTAL

@shenli shenli added component/expression contribution This PR is from a community contributor. labels Sep 9, 2018
@shenli
Copy link
Member

shenli commented Sep 9, 2018

@mccxj Thanks!

@shenli
Copy link
Member

shenli commented Sep 9, 2018

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

@XuHuaiyu PTAL

@shenli
Copy link
Member

shenli commented Sep 10, 2018

/run-all-tests

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 10, 2018
@zz-jason
Copy link
Member

@winoros @eurekaka PTAL

@shenli
Copy link
Member

shenli commented Sep 10, 2018

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 10, 2018
@zz-jason zz-jason merged commit 893d546 into pingcap:master Sep 10, 2018
@mccxj mccxj deleted the builtin_json branch September 10, 2018 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants