Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/tikv,mysql: improve error message of GC life time #7658

Merged
merged 4 commits into from
Sep 11, 2018
Merged

store/tikv,mysql: improve error message of GC life time #7658

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
27beafc
store/tikv,mysql: improve error message of GC life time
tiancaiamao Sep 10, 2018
aa77cac
address comment
tiancaiamao Sep 11, 2018
b95c69d
remove redundant code
tiancaiamao Sep 11, 2018
9f4394e
Merge branch 'master' into gc-life-time
tiancaiamao Sep 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mysql/errname.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,7 +901,7 @@ var MySQLErrName = map[uint16]string{
ErrTiKVServerBusy: "TiKV server is busy",
ErrResolveLockTimeout: "Resolve lock timeout",
ErrRegionUnavailable: "Region is unavailable",
ErrGCTooEarly: "GC life time is shorter than transaction duration",
ErrGCTooEarly: "GC life time is shorter than transaction duration, transaction starts at %v, GC safe point is %v",

ErrTxnTooLarge: "Transaction is too large",
}
2 changes: 1 addition & 1 deletion store/tikv/kv.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ func (s *tikvStore) CheckVisibility(startTime uint64) error {
}

if startTime < cachedSafePoint {
return ErrGCTooEarly
return ErrGCTooEarly.GenByArgs(startTime, cachedSafePoint)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are startTime and cachedSafePoint human readable?

Copy link
Contributor

@winkyao winkyao Sep 11, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

startTime is tso, and the safetime is calculated in GCWorker.prepare, also tso, so both is not readable.

}

return nil
Expand Down