Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plan: exclude IsNull from constant propagation #7835

Merged
merged 3 commits into from
Oct 8, 2018
Merged

plan: exclude IsNull from constant propagation #7835

merged 3 commits into from
Oct 8, 2018

Conversation

eurekaka
Copy link
Contributor

@eurekaka eurekaka commented Oct 8, 2018

What problem does this PR solve?

Fix #7834

What is changed and how it works?

quick return in constant propagation when the ScalarFunction is IsNull

Check List

Tests

  • Integration test

@eurekaka eurekaka added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Oct 8, 2018
winoros
winoros reviewed Oct 8, 2018
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
But this won't make the result wrong?

@eurekaka
Copy link
Contributor Author

eurekaka commented Oct 8, 2018

@winoros yes, the previous result should be fine.

@eurekaka
Copy link
Contributor Author

eurekaka commented Oct 8, 2018

/run-all-tests

@eurekaka eurekaka added status/LGT1 Indicates that a PR has LGTM 1. status/all tests passed labels Oct 8, 2018
crazycs520
crazycs520 reviewed Oct 8, 2018
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520 crazycs520 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 8, 2018
@eurekaka eurekaka merged commit 177c155 into pingcap:master Oct 8, 2018
@eurekaka eurekaka deleted the isnull_propagation branch October 8, 2018 06:47
@eurekaka eurekaka mentioned this pull request Oct 9, 2018
Merged
zz-jason pushed a commit that referenced this pull request Oct 11, 2018
@eurekaka @zz-jason
plan: exclude IsNull from constant propagation(cherry-pick #7835) (#7851
fbdcf63 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@crazycs520 crazycs520 crazycs520 approved these changes

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eurekaka @winoros @crazycs520