Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: fix invailid ddl job panic (#7940) #7958

Merged
merged 2 commits into from
Oct 20, 2018
Merged

ddl: fix invailid ddl job panic (#7940) #7958

merged 2 commits into from
Oct 20, 2018

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

cherry-pick from #7940

What is changed and how it works?

Check List

Tests

  • Unit testCode changes

@zz-jason
Copy link
Member

LGTM

@zz-jason zz-jason added status/LGT1 Indicates that a PR has LGTM 1. component/DDL-need-LGT3 labels Oct 19, 2018
zimulala
zimulala reviewed Oct 19, 2018
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 19, 2018
@zz-jason
Copy link
Member

/run-all-tests

@ngaut ngaut added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Oct 19, 2018
ngaut
ngaut approved these changes Oct 19, 2018
View reviewed changes
Copy link
Member

@ngaut ngaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngaut
Copy link
Member

ngaut commented Oct 20, 2018

/run-all-tests

2 similar comments
@crazycs520
Copy link
Contributor Author

/run-all-tests

@iamxy
Copy link
Member

iamxy commented Oct 20, 2018

/run-all-tests

@ngaut ngaut merged commit 60364fe into pingcap:release-2.1 Oct 20, 2018
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@ngaut ngaut ngaut approved these changes

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@crazycs520 @zz-jason @ngaut @iamxy @zimulala @you06