Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor/aggfuncs: split unit tests to corresponding file #7993

Merged
merged 1 commit into from
Oct 23, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
210 changes: 0 additions & 210 deletions executor/aggfuncs/func_avg_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,51 +24,6 @@ import (
"github.com/pingcap/tidb/util/chunk"
)

func (s *testSuite) TestMergePartialResult4Count(c *C) {
srcChk := chunk.NewChunkWithCapacity([]*types.FieldType{types.NewFieldType(mysql.TypeLonglong)}, 5)
for i := int64(0); i < 5; i++ {
srcChk.AppendInt64(0, i)
}
iter := chunk.NewIterator4Chunk(srcChk)

desc := &aggregation.AggFuncDesc{
Name: ast.AggFuncCount,
Mode: aggregation.CompleteMode,
Args: []expression.Expression{&expression.Column{RetType: types.NewFieldType(mysql.TypeLong), Index: 0}},
}
finalDesc := desc.Split([]int{0})

// build count func for partial phase.
partialCountFunc := aggfuncs.Build(s.ctx, desc, 0)
partialPr1 := partialCountFunc.AllocPartialResult()

// build final func for final phase.
finalCountFunc := aggfuncs.Build(s.ctx, finalDesc, 0)
finalPr := finalCountFunc.AllocPartialResult()
resultChk := chunk.NewChunkWithCapacity([]*types.FieldType{types.NewFieldType(mysql.TypeLonglong)}, 1)

// update partial result.
for row := iter.Begin(); row != iter.End(); row = iter.Next() {
partialCountFunc.UpdatePartialResult(s.ctx, []chunk.Row{row}, partialPr1)
}
partialCountFunc.AppendFinalResult2Chunk(s.ctx, partialPr1, resultChk)
c.Assert(resultChk.GetRow(0).GetInt64(0), Equals, int64(5))

// suppose there are two partial workers.
partialPr2 := partialPr1

// merge two partial results.
err := finalCountFunc.MergePartialResult(s.ctx, partialPr1, finalPr)
c.Assert(err, IsNil)
err = finalCountFunc.MergePartialResult(s.ctx, partialPr2, finalPr)
c.Assert(err, IsNil)

resultChk.Reset()
err = finalCountFunc.AppendFinalResult2Chunk(s.ctx, finalPr, resultChk)
c.Assert(err, IsNil)
c.Assert(resultChk.GetRow(0).GetInt64(0), Equals, int64(10))
}

func (s *testSuite) TestMergePartialResult4AvgDecimal(c *C) {
srcChk := chunk.NewChunkWithCapacity([]*types.FieldType{types.NewFieldType(mysql.TypeNewDecimal)}, 5)
for i := int64(0); i < 5; i++ {
Expand Down Expand Up @@ -180,168 +135,3 @@ func (s *testSuite) TestMergePartialResult4AvgFloat(c *C) {
// (10 + 9) / 8
c.Assert(resultChk.GetRow(0).GetFloat64(0) == float64(2.375), IsTrue)
}

func (s *testSuite) TestMergePartialResult4SumDecimal(c *C) {
srcChk := chunk.NewChunkWithCapacity([]*types.FieldType{types.NewFieldType(mysql.TypeNewDecimal)}, 5)
for i := int64(0); i < 5; i++ {
srcChk.AppendMyDecimal(0, types.NewDecFromInt(i))
}
iter := chunk.NewIterator4Chunk(srcChk)

desc := &aggregation.AggFuncDesc{
Name: ast.AggFuncSum,
Mode: aggregation.CompleteMode,
Args: []expression.Expression{&expression.Column{RetType: types.NewFieldType(mysql.TypeLonglong), Index: 0}},
RetTp: types.NewFieldType(mysql.TypeNewDecimal),
}
finalDesc := desc.Split([]int{0})

// build sum func for partial phase.
partialSumFunc := aggfuncs.Build(s.ctx, desc, 0)
partialPr1 := partialSumFunc.AllocPartialResult()
partialPr2 := partialSumFunc.AllocPartialResult()

// build final func for final phase.
finalAvgFunc := aggfuncs.Build(s.ctx, finalDesc, 0)
finalPr := finalAvgFunc.AllocPartialResult()
resultChk := chunk.NewChunkWithCapacity([]*types.FieldType{types.NewFieldType(mysql.TypeNewDecimal)}, 1)

// update partial result.
for row := iter.Begin(); row != iter.End(); row = iter.Next() {
partialSumFunc.UpdatePartialResult(s.ctx, []chunk.Row{row}, partialPr1)
}
// 0+1+2+3+4
partialSumFunc.AppendFinalResult2Chunk(s.ctx, partialPr1, resultChk)
c.Assert(resultChk.GetRow(0).GetMyDecimal(0).Compare(types.NewDecFromInt(10)) == 0, IsTrue)

row := iter.Begin()
row = iter.Next()
for row = iter.Next(); row != iter.End(); row = iter.Next() {
partialSumFunc.UpdatePartialResult(s.ctx, []chunk.Row{row}, partialPr2)
}
resultChk.Reset()
// 2+3+4
partialSumFunc.AppendFinalResult2Chunk(s.ctx, partialPr2, resultChk)
c.Assert(resultChk.GetRow(0).GetMyDecimal(0).Compare(types.NewDecFromInt(9)) == 0, IsTrue)

// merge two partial results.
err := finalAvgFunc.MergePartialResult(s.ctx, partialPr1, finalPr)
c.Assert(err, IsNil)
err = finalAvgFunc.MergePartialResult(s.ctx, partialPr2, finalPr)
c.Assert(err, IsNil)

resultChk.Reset()
err = finalAvgFunc.AppendFinalResult2Chunk(s.ctx, finalPr, resultChk)
c.Assert(err, IsNil)
// 10+9
c.Assert(resultChk.GetRow(0).GetMyDecimal(0).Compare(types.NewDecFromInt(19)) == 0, IsTrue)
}

func (s *testSuite) TestMergePartialResult4SumFloat(c *C) {
srcChk := chunk.NewChunkWithCapacity([]*types.FieldType{types.NewFieldType(mysql.TypeDouble)}, 5)
for i := int64(0); i < 5; i++ {
srcChk.AppendFloat64(0, float64(i))
}
iter := chunk.NewIterator4Chunk(srcChk)

desc := &aggregation.AggFuncDesc{
Name: ast.AggFuncSum,
Mode: aggregation.CompleteMode,
Args: []expression.Expression{&expression.Column{RetType: types.NewFieldType(mysql.TypeDouble), Index: 0}},
RetTp: types.NewFieldType(mysql.TypeDouble),
}
finalDesc := desc.Split([]int{0})

// build sum func for partial phase.
partialSumFunc := aggfuncs.Build(s.ctx, desc, 0)
partialPr1 := partialSumFunc.AllocPartialResult()
partialPr2 := partialSumFunc.AllocPartialResult()

// build final func for final phase.
finalAvgFunc := aggfuncs.Build(s.ctx, finalDesc, 0)
finalPr := finalAvgFunc.AllocPartialResult()
resultChk := chunk.NewChunkWithCapacity([]*types.FieldType{types.NewFieldType(mysql.TypeDouble)}, 1)

// update partial result.
for row := iter.Begin(); row != iter.End(); row = iter.Next() {
partialSumFunc.UpdatePartialResult(s.ctx, []chunk.Row{row}, partialPr1)
}
partialSumFunc.AppendFinalResult2Chunk(s.ctx, partialPr1, resultChk)
// (0+1+2+3+4)
c.Assert(resultChk.GetRow(0).GetFloat64(0) == float64(10), IsTrue)

row := iter.Begin()
row = iter.Next()
for row = iter.Next(); row != iter.End(); row = iter.Next() {
partialSumFunc.UpdatePartialResult(s.ctx, []chunk.Row{row}, partialPr2)
}
resultChk.Reset()
partialSumFunc.AppendFinalResult2Chunk(s.ctx, partialPr2, resultChk)
// (2+3+4)
c.Assert(resultChk.GetRow(0).GetFloat64(0) == float64(9), IsTrue)

// merge two partial results.
err := finalAvgFunc.MergePartialResult(s.ctx, partialPr1, finalPr)
c.Assert(err, IsNil)
err = finalAvgFunc.MergePartialResult(s.ctx, partialPr2, finalPr)
c.Assert(err, IsNil)

resultChk.Reset()
err = finalAvgFunc.AppendFinalResult2Chunk(s.ctx, finalPr, resultChk)
c.Assert(err, IsNil)
// (10 + 9)
c.Assert(resultChk.GetRow(0).GetFloat64(0) == float64(19), IsTrue)
}

func (s *testSuite) TestMergePartialResult4MaxFloat(c *C) {
srcChk := chunk.NewChunkWithCapacity([]*types.FieldType{types.NewFieldType(mysql.TypeDouble)}, 5)
for i := int64(0); i < 5; i++ {
srcChk.AppendFloat64(0, float64(i))
}
iter := chunk.NewIterator4Chunk(srcChk)

desc := &aggregation.AggFuncDesc{
Name: ast.AggFuncMax,
Mode: aggregation.CompleteMode,
Args: []expression.Expression{&expression.Column{RetType: types.NewFieldType(mysql.TypeDouble), Index: 0}},
RetTp: types.NewFieldType(mysql.TypeDouble),
}
finalDesc := desc.Split([]int{0})

// build max func for partial phase.
partialMaxFunc := aggfuncs.Build(s.ctx, desc, 0)
partialPr1 := partialMaxFunc.AllocPartialResult()
partialPr2 := partialMaxFunc.AllocPartialResult()

// build final func for final phase.
finalAvgFunc := aggfuncs.Build(s.ctx, finalDesc, 0)
finalPr := finalAvgFunc.AllocPartialResult()
resultChk := chunk.NewChunkWithCapacity([]*types.FieldType{types.NewFieldType(mysql.TypeDouble)}, 1)

// update partial result.
for row := iter.Begin(); row != iter.End(); row = iter.Next() {
partialMaxFunc.UpdatePartialResult(s.ctx, []chunk.Row{row}, partialPr1)
}
partialMaxFunc.AppendFinalResult2Chunk(s.ctx, partialPr1, resultChk)
c.Assert(resultChk.GetRow(0).GetFloat64(0) == float64(4), IsTrue)

row := iter.Begin()
row = iter.Next()
for row = iter.Next(); row != iter.End(); row = iter.Next() {
partialMaxFunc.UpdatePartialResult(s.ctx, []chunk.Row{row}, partialPr2)
}
resultChk.Reset()
partialMaxFunc.AppendFinalResult2Chunk(s.ctx, partialPr2, resultChk)
c.Assert(resultChk.GetRow(0).GetFloat64(0) == float64(4), IsTrue)

// merge two partial results.
err := finalAvgFunc.MergePartialResult(s.ctx, partialPr1, finalPr)
c.Assert(err, IsNil)
err = finalAvgFunc.MergePartialResult(s.ctx, partialPr2, finalPr)
c.Assert(err, IsNil)

resultChk.Reset()
err = finalAvgFunc.AppendFinalResult2Chunk(s.ctx, finalPr, resultChk)
c.Assert(err, IsNil)
c.Assert(resultChk.GetRow(0).GetFloat64(0) == float64(4), IsTrue)
}
70 changes: 70 additions & 0 deletions executor/aggfuncs/func_count_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
// Copyright 2018 PingCAP, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// See the License for the specific language governing permissions and
// limitations under the License.

package aggfuncs_test

import (
. "github.com/pingcap/check"
"github.com/pingcap/tidb/ast"
"github.com/pingcap/tidb/executor/aggfuncs"
"github.com/pingcap/tidb/expression"
"github.com/pingcap/tidb/expression/aggregation"
"github.com/pingcap/tidb/mysql"
"github.com/pingcap/tidb/types"
"github.com/pingcap/tidb/util/chunk"
)

func (s *testSuite) TestMergePartialResult4Count(c *C) {
srcChk := chunk.NewChunkWithCapacity([]*types.FieldType{types.NewFieldType(mysql.TypeLonglong)}, 5)
for i := int64(0); i < 5; i++ {
srcChk.AppendInt64(0, i)
}
iter := chunk.NewIterator4Chunk(srcChk)

desc := &aggregation.AggFuncDesc{
Name: ast.AggFuncCount,
Mode: aggregation.CompleteMode,
Args: []expression.Expression{&expression.Column{RetType: types.NewFieldType(mysql.TypeLong), Index: 0}},
}
finalDesc := desc.Split([]int{0})

// build count func for partial phase.
partialCountFunc := aggfuncs.Build(s.ctx, desc, 0)
partialPr1 := partialCountFunc.AllocPartialResult()

// build final func for final phase.
finalCountFunc := aggfuncs.Build(s.ctx, finalDesc, 0)
finalPr := finalCountFunc.AllocPartialResult()
resultChk := chunk.NewChunkWithCapacity([]*types.FieldType{types.NewFieldType(mysql.TypeLonglong)}, 1)

// update partial result.
for row := iter.Begin(); row != iter.End(); row = iter.Next() {
partialCountFunc.UpdatePartialResult(s.ctx, []chunk.Row{row}, partialPr1)
}
partialCountFunc.AppendFinalResult2Chunk(s.ctx, partialPr1, resultChk)
c.Assert(resultChk.GetRow(0).GetInt64(0), Equals, int64(5))

// suppose there are two partial workers.
partialPr2 := partialPr1

// merge two partial results.
err := finalCountFunc.MergePartialResult(s.ctx, partialPr1, finalPr)
c.Assert(err, IsNil)
err = finalCountFunc.MergePartialResult(s.ctx, partialPr2, finalPr)
c.Assert(err, IsNil)

resultChk.Reset()
err = finalCountFunc.AppendFinalResult2Chunk(s.ctx, finalPr, resultChk)
c.Assert(err, IsNil)
c.Assert(resultChk.GetRow(0).GetInt64(0), Equals, int64(10))
}
78 changes: 78 additions & 0 deletions executor/aggfuncs/func_max_min_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
// Copyright 2018 PingCAP, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// See the License for the specific language governing permissions and
// limitations under the License.

package aggfuncs_test

import (
. "github.com/pingcap/check"
"github.com/pingcap/tidb/ast"
"github.com/pingcap/tidb/executor/aggfuncs"
"github.com/pingcap/tidb/expression"
"github.com/pingcap/tidb/expression/aggregation"
"github.com/pingcap/tidb/mysql"
"github.com/pingcap/tidb/types"
"github.com/pingcap/tidb/util/chunk"
)

func (s *testSuite) TestMergePartialResult4MaxFloat(c *C) {
srcChk := chunk.NewChunkWithCapacity([]*types.FieldType{types.NewFieldType(mysql.TypeDouble)}, 5)
for i := int64(0); i < 5; i++ {
srcChk.AppendFloat64(0, float64(i))
}
iter := chunk.NewIterator4Chunk(srcChk)

desc := &aggregation.AggFuncDesc{
Name: ast.AggFuncMax,
Mode: aggregation.CompleteMode,
Args: []expression.Expression{&expression.Column{RetType: types.NewFieldType(mysql.TypeDouble), Index: 0}},
RetTp: types.NewFieldType(mysql.TypeDouble),
}
finalDesc := desc.Split([]int{0})

// build max func for partial phase.
partialMaxFunc := aggfuncs.Build(s.ctx, desc, 0)
partialPr1 := partialMaxFunc.AllocPartialResult()
partialPr2 := partialMaxFunc.AllocPartialResult()

// build final func for final phase.
finalMaxFunc := aggfuncs.Build(s.ctx, finalDesc, 0)
finalPr := finalMaxFunc.AllocPartialResult()
resultChk := chunk.NewChunkWithCapacity([]*types.FieldType{types.NewFieldType(mysql.TypeDouble)}, 1)

// update partial result.
for row := iter.Begin(); row != iter.End(); row = iter.Next() {
partialMaxFunc.UpdatePartialResult(s.ctx, []chunk.Row{row}, partialPr1)
}
partialMaxFunc.AppendFinalResult2Chunk(s.ctx, partialPr1, resultChk)
c.Assert(resultChk.GetRow(0).GetFloat64(0) == float64(4), IsTrue)

row := iter.Begin()
row = iter.Next()
for row = iter.Next(); row != iter.End(); row = iter.Next() {
partialMaxFunc.UpdatePartialResult(s.ctx, []chunk.Row{row}, partialPr2)
}
resultChk.Reset()
partialMaxFunc.AppendFinalResult2Chunk(s.ctx, partialPr2, resultChk)
c.Assert(resultChk.GetRow(0).GetFloat64(0) == float64(4), IsTrue)

// merge two partial results.
err := finalMaxFunc.MergePartialResult(s.ctx, partialPr1, finalPr)
c.Assert(err, IsNil)
err = finalMaxFunc.MergePartialResult(s.ctx, partialPr2, finalPr)
c.Assert(err, IsNil)

resultChk.Reset()
err = finalMaxFunc.AppendFinalResult2Chunk(s.ctx, finalPr, resultChk)
c.Assert(err, IsNil)
c.Assert(resultChk.GetRow(0).GetFloat64(0) == float64(4), IsTrue)
}
Loading