parser: Add more keywords into UnReservedKeyword list #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
year and now are time functions, it is ok not adding in function parser? |
|
It is OK. |
|
LGTM |
|
Merge with master and fix conflict and fix golint error. |
|
|
||
| "AUTO_INCREMENT" | "AFTER" | "BEGIN" | "BIT" | "BOOL" | "BOOLEAN" | "CHARSET" | "COLUMNS" | "COMMIT" | ||
| | "DATE" | "DATETIME" | "DEALLOCATE" | "DO" | "END" | "ENGINE" | "ENGINES" | "EXECUTE" | "FIRST" | "FULL" | ||
| | "LOCAL" | "NAMES" | "OFFSET" | "PASSWORD" %prec lowerThanEq | "PREPARE" | "QUICK" | "ROLLBACK" | "SESSION" | "SIGNED" |
There was a problem hiding this comment.
should we put PASSWORD in a single line, because it has a precedence.
There was a problem hiding this comment.
Not necessary. We have "|" to separate different rules. So I think the %prec will not affect other rules.
There was a problem hiding this comment.
I know that %prec will not affect other rules. I just think it seems different from others with %prec.
Address comment
|
PTAL |
|
LGTM |
1 similar comment
|
LGTM |
ngaut
added a commit
that referenced
this pull request
Sep 10, 2015
parser: Add more keywords into UnReservedKeyword list
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
* docs: update for 2.1 * docs: added Chinese translation * docs: fixed comments * Update docs/en_US/02-Deployment.md Co-Authored-By: kennytm <[email protected]> * Update docs/en_US/02-Deployment.md Co-Authored-By: kennytm <[email protected]> * Update docs/en_US/02-Deployment.md Co-Authored-By: kennytm <[email protected]> * Update docs/en_US/02-Deployment.md Co-Authored-By: kennytm <[email protected]> * Update docs/en_US/05-Errors.md Co-Authored-By: kennytm <[email protected]> * Update docs/en_US/05-Errors.md Co-Authored-By: kennytm <[email protected]> * Update docs/en_US/05-Errors.md Co-Authored-By: kennytm <[email protected]> * Update docs/en_US/05-Errors.md Co-Authored-By: kennytm <[email protected]> * docs: addressed comments * Update README.md Co-Authored-By: kennytm <[email protected]>
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Sep 28, 2021
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Oct 8, 2021
ti-chi-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
okJiang
pushed a commit
to okJiang/tidb
that referenced
this pull request
Oct 19, 2021
Co-authored-by: Chunzhu Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://dev.mysql.com/doc/refman/5.7/en/keywords.html
Unreserved keywords can be used as identifiers.