tikvclient: Add endKey param to Scanner #8178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
MyonKeminta
changed the title
Signed-off-by: MyonKeminta <[email protected]>
|
/run-integration-tests tikv=pr/3720 |
Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
MyonKeminta
changed the title
Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
|
/run-integration-tests |
|
LGTM. PTAL @zhangjinpeng1987 |
|
Emmmm why is circleci canceled.. |
Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
|
@tiancaiamao PTAL.. |
tiancaiamao
reviewed
Nov 8, 2018
| @@ -199,7 +202,7 @@ func (s *Scanner) getData(bo *Backoffer) error { | |||
| // No more data in current Region. Next getData() starts | |||
| // from current Region's endKey. | |||
| s.nextStartKey = loc.EndKey | |||
| if len(loc.EndKey) == 0 { | |||
| if len(loc.EndKey) == 0 || (len(s.endKey) > 0 && kv.Key(s.nextStartKey).Cmp(kv.Key(s.endKey)) >= 0) { | |||
There was a problem hiding this comment.
I find s.endKey == nil and s.endKey == []byte{} is not distinguished
Should we make it clear? or it's deliberately?
s.endKey == nil -- nobody set it
s.endKey == []byte{} -- it's actually set to a wrong value
There was a problem hiding this comment.
I tries to regards nil and empty the same, so I simply use len to judge whether it's set.
|
/run-all-tests |
|
/rebuild |
|
@tiancaiamao Can you help me re-run the circleci? |
|
LGTM |
tiancaiamao
added
status/all tests passed
status/LGT2
tiancaiamao
approved these changes
Nov 8, 2018
MyonKeminta
added a commit
to MyonKeminta/tidb
that referenced
this pull request
Nov 9, 2018
Signed-off-by: MyonKeminta <[email protected]>
2 tasks
zz-jason
pushed a commit
that referenced
this pull request
Nov 12, 2018
MyonKeminta
added a commit
to MyonKeminta/tidb
that referenced
this pull request
Nov 14, 2018
Signed-off-by: MyonKeminta <[email protected]>
winkyao
pushed a commit
that referenced
this pull request
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR is extracted from #8081 .
What is changed and how it works?
This PR updated kvproto to the newest so there is the EndKey param in kv scan RPC call. Then endKey was added to Scanner as an extra param of func
newScanner.Also, an upperBound parameter was added to the
Seekmethod ofRetrieverinterface, and the method was renamed toIter.This PR should be merged after tikv/tikv#3720 .(Done)Check List
Tests
Code changes
Side effects
None
Related changes
None