Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: support for "admin show next_row_id" #8242

Merged
merged 8 commits into from
Nov 9, 2018

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Nov 8, 2018

What problem does this PR solve?

Before this PR, we only can get the table's auto-increment ID. Now we want to know the next global row ID.

What is changed and how it works?

Support for "admin show next_row_id".

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

@zimulala
Copy link
Contributor Author

zimulala commented Nov 8, 2018

After we merge the PR of #7965, I will handle conflicts with the file of go.mod.

@zimulala
Copy link
Contributor Author

zimulala commented Nov 8, 2018

PTAL @jackysp @winkyao

@zimulala zimulala added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Nov 9, 2018
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reset LGTM

planner/core/planbuilder.go Outdated Show resolved Hide resolved
planner/core/planbuilder.go Outdated Show resolved Hide resolved
planner/core/planbuilder.go Outdated Show resolved Hide resolved
@zimulala
Copy link
Contributor Author

zimulala commented Nov 9, 2018

PTAL @jackysp @crazycs520 @zz-jason

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 9, 2018
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added status/LGT2 Indicates that a PR has LGTM 2. status/LGT3 The PR has already had 3 LGTM. and removed status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. labels Nov 9, 2018
@jackysp
Copy link
Member

jackysp commented Nov 9, 2018

/run-all-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants