Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gc_worker: add gc enable variable to enable/disable gc #8282

Merged
merged 20 commits into from
Dec 3, 2018
Merged

gc_worker: add gc enable variable to enable/disable gc #8282

merged 20 commits into from
Dec 3, 2018

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Nov 12, 2018 •
edited by c4pt0r
Loading

What problem does this PR solve?

Add gc_enable to mysql.tidb to control GC status.
This for #7937

What is changed and how it works?

check gc_enable variable value in before interval run GC.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

This change is Reviewable

@ciscoxll
Copy link
Contributor

/run-all-tests

alivxxx
alivxxx reviewed Nov 13, 2018
View reviewed changes
store/tikv/gcworker/gc_worker.go Outdated Show resolved Hide resolved
store/tikv/gcworker/gc_worker.go Outdated Show resolved Hide resolved
@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520
Copy link
Contributor Author

/run-integration-ddl-test

winkyao
winkyao reviewed Nov 22, 2018
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520 crazycs520 added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 27, 2018
@crazycs520 crazycs520 added status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Dec 3, 2018
zimulala
zimulala approved these changes Dec 3, 2018
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 3, 2018
@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520
Copy link
Contributor Author

/run-sqllogic-test

@crazycs520
Copy link
Contributor Author

/run-integration-ddl-test

@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520 crazycs520 merged commit 8ddeeea into pingcap:master Dec 3, 2018
iamzhoug37 pushed a commit to iamzhoug37/tidb that referenced this pull request Dec 13, 2018
@crazycs520 @iamzhoug37
gc_worker: add gc enable variable to enable/disable gc (pingcap#8282)
7dc8c96
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alivxxx alivxxx alivxxx left review comments

@MyonKeminta MyonKeminta MyonKeminta left review comments

@winkyao winkyao winkyao left review comments

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@crazycs520 @ciscoxll @zimulala @winkyao @MyonKeminta @alivxxx @you06