-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: support builtin function "benchmark" #8313
Conversation
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
673acd8
to
dc7ccd1
Compare
@vikingM Please fix the CI. |
998af7c
to
d50920e
Compare
the conflict file just because when i create a json object, i found in "datumsToConstants" think it is a string object |
Please merge the latest master branch and resolve conflicts. |
@vikingM Please merge the latest master and resolve conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @vikingM
Please add some integration cases for benchmark
.
@vikingM any update? there is a conflict between this and the master branch. Could you update to the latest master and resolve the conflicts in your spare time? |
So sorry. I'll resolve the conflict before Friday.
Zhang Jian <[email protected]> 于2019年1月8日周二 下午2:42写道:
… @vikingM <https://github.com/vikingM> any update? there is a conflict
between this and the master branch. Could you update to the latest master
and resolve the conflicts in your spare time?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8313 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AYd4cazXL6CHfoNuDYKWPPSjFP4rMTE5ks5vBD3EgaJpZM4YdYIP>
.
|
Codecov Report
@@ Coverage Diff @@
## master #8313 +/- ##
=========================================
- Coverage 67.55% 67.5% -0.05%
=========================================
Files 363 363
Lines 75301 75423 +122
=========================================
+ Hits 50868 50918 +50
- Misses 19940 19997 +57
- Partials 4493 4508 +15
Continue to review full report at Codecov.
|
{[]interface{}{1000, types.NewDecFromFloatForTest(1.1)}, 0, false, false}, | ||
{[]interface{}{1000, types.Duration{Duration: time.Duration(0)}}, 0, false, false}, | ||
{[]interface{}{1000, jsonObj}, 0, false, false}, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add some cases that generate some errors or nil results~?
What problem does this PR solve?
#6774
What is changed and how it works?
add the benchmark function
now this function args are (int,string)
Check List
Tests
select benchmark(10000,md5(rand()));
Code changes
in expression/builtin_info.go
add the related codes
This change is