Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: properly escape backquotes in identifiers in SHOW CREATE TABLE #8321

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented Nov 14, 2018

What problem does this PR solve?

This is a backport of #8302 to the release-2.0 branch.

What is changed and how it works?

This PR cherry-picks #8302 (f88db4f) to the release-2.0 branch.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

@zz-jason
Copy link
Member

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 14, 2018
@kennytm
Copy link
Contributor Author

kennytm commented Nov 14, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@winoros winoros added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 14, 2018
@zz-jason zz-jason merged commit 33869c1 into pingcap:release-2.0 Nov 15, 2018
@kennytm kennytm deleted the fix-8259-2.0 branch November 15, 2018 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants