-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sessionctx: Error/warning on unsupported isolation levels #8625
Conversation
/run-all-tests |
/rebuild |
I have changed |
/run-all-tests |
It looks like this does break the JDBC test:
This is the side-effect mentioned in the PR. Some applications will break on warnings too, particularly since |
/run-all-tests |
I was concerned that a warning for |
/run-all-tests tidb-test=pr/683 |
LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
)" This reverts commit c27705a.
What problem does this PR solve?
Fixes #2712
What is changed and how it works?
For isolation levels, the following behavior is provided:
Check List
Tests
Code changes
Side effects
read-uncommitted
orserializable
, but they are less common than RR and RC)Related changes
This change is