Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: reset bound arguments when it is executed by execute command (#8645) #8652

Merged
merged 2 commits into from
Dec 12, 2018
Merged

server: reset bound arguments when it is executed by execute command (#8645) #8652

merged 2 commits into from
Dec 12, 2018

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Dec 11, 2018 •
edited by c4pt0r
Loading

What problem does this PR solve?

Cherry-pick #8645 to release 2.1.

PTAL @zimulala @lysu

This change is Reviewable

zimulala
zimulala reviewed Dec 11, 2018
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT1 Indicates that a PR has LGTM 1. component/DDL-need-LGT3 labels Dec 11, 2018
@zhouqiang-cl
Copy link
Contributor

/rebuild

lysu
lysu approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 11, 2018
@jackysp
Copy link
Member Author

jackysp commented Dec 12, 2018

/run-all-tests tidb-test=pr/690 tikv=release-2.1 pd=release-2.1

@jackysp jackysp merged commit dcfff79 into pingcap:release-2.1 Dec 12, 2018
@jackysp jackysp deleted the reset_params_2.1 branch February 11, 2019 07:13
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@lysu lysu lysu approved these changes

Assignees
No one assigned
Labels
component/server sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jackysp @zhouqiang-cl @lysu @zimulala @you06