server: close all connection directly when terminate tidb #8692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@winkyao @tiancaiamao PTAL |
|
/run-all-tests |
winkyao
reviewed
Dec 14, 2018
winkyao
added
the
priority/release-blocker
tiancaiamao
reviewed
Dec 14, 2018
| @@ -153,6 +153,10 @@ func (cc *clientConn) Close() error { | |||
| delete(cc.server.clients, cc.connectionID) | |||
| connections := len(cc.server.clients) | |||
| cc.server.rwlock.Unlock() | |||
| return closeConn(cc, connections) | |||
There was a problem hiding this comment.
Will Close be called twice?
There was a problem hiding this comment.
Normally won't.
https://github.com/pingcap/tidb/blob/master/server/conn.go#L458 There will check connection status to avoid double close.
|
LGTM |
|
Please stop the schemaValidator in the beginning of the domain.Close. |
zimulala
reviewed
Dec 14, 2018
|
/rebuild |
|
/run-all-tests |
|
/run-unit-test |
|
/run-common-test |
winkyao
reviewed
Dec 15, 2018
crazycs520
force-pushed
the
kill-tidb-conn-master
branch
from
3eefde1
to
ce96f37
Compare
crazycs520
force-pushed
the
kill-tidb-conn-master
branch
from
ce96f37
to
fb0bab1
Compare
|
/run-all-tests |
|
/rebuild |
|
/rebuild |
|
/run-all-tests |
|
/rebuild |
|
/run-all-tests |
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Dec 17, 2018
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Dec 17, 2018
This was referenced Dec 17, 2018
winkyao
pushed a commit
that referenced
this pull request
Dec 17, 2018
zz-jason
pushed a commit
that referenced
this pull request
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Close all connection directly when terminate tidb.
Currently, if TiDB got terminated signal, TiDB will call
cancelFuncof the connection. But callcancelFuncwill make the result be uncertainty to client.So just close the connections and return error.
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
This change is