Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add binlog socket config for compatible with kafka version pump #8732

Merged
merged 7 commits into from
Dec 19, 2018
Merged

add binlog socket config for compatible with kafka version pump #8732

merged 7 commits into from
Dec 19, 2018

Conversation

WangXiangUSTC
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC commented Dec 18, 2018 •
edited by c4pt0r
Loading

What problem does this PR solve?

add binlog socket config for compatible with kafka version pump

What is changed and how it works?

add a new config binlogsocket
if binlogsocket is not empty, will use pumpcli.NewLocalPumpsClient to create a pump client, and this pump client will only write binlog to the local pump by this socket file.

Check List

Tests

  • Integration test
  • Manual test
    set binlogsocket, and deploy kafka version pump, write data and then check

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

This change is Reviewable

@WangXiangUSTC
Copy link
Contributor Author

@jackysp @GregoryIan @july2993 PTAL

jackysp
jackysp reviewed Dec 18, 2018
View reviewed changes
tidb-server/main.go Outdated Show resolved Hide resolved
@zhouqiang-cl
Copy link
Contributor

/rebuild

@pingcap pingcap deleted a comment from zhouqiang-cl Dec 19, 2018
jackysp
jackysp reviewed Dec 19, 2018
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 19, 2018
@IANTHEREAL
Copy link
Contributor

LGTM

IANTHEREAL
IANTHEREAL approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@IANTHEREAL IANTHEREAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC merged commit 2f54639 into pingcap:master Dec 19, 2018
@WangXiangUSTC WangXiangUSTC mentioned this pull request Dec 19, 2018
Merged
yu34po pushed a commit to yu34po/tidb that referenced this pull request Jan 2, 2019
@WangXiangUSTC @yu34po
add binlog socket config for compatible with kafka version pump (ping…
bc9d4ee 
…cap#8732)
@WangXiangUSTC WangXiangUSTC deleted the xiang/binlog_compatible branch January 24, 2019 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@IANTHEREAL IANTHEREAL IANTHEREAL approved these changes

Assignees
No one assigned
Labels
component/binlog status/LGT1 Indicates that a PR has LGTM 1. type/compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WangXiangUSTC @zhouqiang-cl @IANTHEREAL @jackysp