gc_worker: Remove timezone name from the times that are saved in mysql.tidb #8745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
|
/run-all-tests |
|
@MyonKeminta Please fix ci |
|
LGTM |
|
/run-common-test |
|
Sorry.. I didn't make it to figure out what was wrong with CI... |
|
/run-common-test |
|
/run-common-test |
|
/run-all-tests |
|
/run-unit-test |
1 similar comment
|
/run-unit-test |
breezewish
previously approved these changes
Dec 25, 2018
|
@zhexuany PTAL again thanks! |
|
@disksing PTAL |
disksing
reviewed
Dec 25, 2018
Signed-off-by: MyonKeminta <[email protected]>
disksing
reviewed
Dec 26, 2018
disksing
reviewed
Dec 26, 2018
| if err != nil { | ||
| // Remove the last field that separated by space | ||
| parts := strings.Split(value, " ") | ||
| prefix := strings.Join(parts[:len(parts)-1], " ") |
There was a problem hiding this comment.
No, it should returns at least one parts. You split "" by " " then you should got [""]. You can also see that the test has passed.
Signed-off-by: MyonKeminta <[email protected]>
MyonKeminta
added
status/LGT2
|
/run-all-tests |
disksing
approved these changes
Dec 26, 2018
disksing
added
status/LGT3
|
/run-unit-test |
|
/run-all-tests |
|
/run-all-tests |
yu34po
pushed a commit
to yu34po/tidb
that referenced
this pull request
Jan 2, 2019
…l.tidb (pingcap#8745) Signed-off-by: MyonKeminta <[email protected]>
XuHuaiyu
pushed a commit
to XuHuaiyu/tidb
that referenced
this pull request
May 29, 2019
…l.tidb (pingcap#8745) Signed-off-by: MyonKeminta <[email protected]>
ngaut
pushed a commit
that referenced
this pull request
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
gc_worker saves some times in mysql.tidb. These times are:
tikv_gc_safe_point,tikv_gc_last_run_time,tikv_gc_leader_lease.Now our format is
20060102-15:04:05 -0700 MST. The time zone is specified twice by"-0700"and"MST". This seems to be ok, but unfortunately it caused a problem: in some environments, it can't get a timezone name properly, only to produce something like"20181218-19:53:37 +0800 +08". Then if we try to load it from the table, we will get an error when parsing the string, which sayscannot parse "+08" as "MST".This PR tries to solve this problem by deprecating the last field
"MST", but still be able to load the time with the old format.What is changed and how it works?
A function named
ParseTimeFromPrefixwas added. It tries to parse a time with specified format from a prefix of a given string, and the string should contain a space that separate the prefix and the rest of the string. So when we use this function to parse the string"20181218-19:53:37 +0800 +08"or"20181218-19:53:37 +0800 CST"with the format"20060102-15:04:05 -0700", we actually ignored the last"+08"or"CST". So it's compatible with old format.Check List
Tests
Code changes
ParseTimeFromPrefix20060102-15:04:05 -0700 MSTto20060102-15:04:05 -0700Side effects
Related changes
This change is