Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: dynamic adjust add index worker number. (#8295) #8786

Merged
merged 2 commits into from
Dec 25, 2018

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Dec 24, 2018

What problem does this PR solve?

cherry-pick #8295

What is changed and how it works?

Check List

Tests

Code changes

Side effects

Related changes


This change is Reviewable

@crazycs520
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@crazycs520
Copy link
Contributor Author

/run-integration-common-test tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

1 similar comment
@crazycs520
Copy link
Contributor Author

/run-integration-common-test tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 24, 2018
@crazycs520
Copy link
Contributor Author

/run-integration-compatibility-test tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zimulala
Copy link
Contributor

PTAL @winkyao @ciscoxll

@winkyao
Copy link
Contributor

winkyao commented Dec 25, 2018

@crazycs520 Cherry-pick needn't three LGTM.

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. component/DDL-need-LGT3 and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 25, 2018
@zz-jason zz-jason merged commit d805e83 into pingcap:release-2.1 Dec 25, 2018
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants