planner, privilege: check user priv on SET GLOBAL #8837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @tiancaiamao , thx! |
|
/run-all-tests |
zimulala
reviewed
Dec 28, 2018
alivxxx
added
status/LGT2
Codecov Report
@@ Coverage Diff @@
## master #8837 +/- ##
=========================================
Coverage ? 67.54%
=========================================
Files ? 363
Lines ? 75101
Branches ? 0
=========================================
Hits ? 50725
Misses ? 19903
Partials ? 4473
Continue to review full report at Codecov.
|
ngaut
approved these changes
Jan 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fixes #7403
What is changed and how it works?
Checks that
SET GLOBALrequires the super privilege. Does not check any session level vars - I took a look, and I don't believe any in TiDB require privilege check.(In MySQL commands like
SET SESSION sql_log_bin=0require super privs, but I believe this is not applicable to TiDB).It is not 100% compatible with MySQL, since the error codes/messages differ, but this is not a new issue, and is inherint to all checking in
visitInfo. I will create a separate issue to discuss how to enhance it, since I think it should have an argument to pass the error message on failure.Check List
Tests
Code changes
Side effects
Related changes
This change is