Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: clean up code for insert/update statement #8867

Merged
merged 3 commits into from
Dec 29, 2018
Merged

*: clean up code for insert/update statement #8867

merged 3 commits into from
Dec 29, 2018

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Dec 28, 2018 •
edited
Loading

What problem does this PR solve?

  1. metrics of batch get will always inc(1) even if nothing to get.
  2. kv.SkipCheckForWrite is unused for a long while tikv/2pc:disable skip_contraint_check #3600, make a cleanup.
  3. some other cleanup.

What is changed and how it works?

Fix them.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported variable/fields change

This change is Reviewable

@jackysp jackysp requested review from lysu and winkyao December 28, 2018 14:58
@jackysp
Copy link
Member Author

jackysp commented Dec 28, 2018

/run-all-tests

@ngaut
Copy link
Member

ngaut commented Dec 29, 2018

We should remove SkipCheckForWrite completely.

lysu
lysu reviewed Dec 29, 2018
View reviewed changes
store/tikv/snapshot.go Show resolved Hide resolved
table/tables/tables.go Show resolved Hide resolved
lysu
lysu reviewed Dec 29, 2018
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackysp
Copy link
Member Author

jackysp commented Dec 29, 2018

PTAL @ngaut @winkyao

@jackysp
Copy link
Member Author

jackysp commented Dec 29, 2018

/run-all-tests

winkyao
winkyao approved these changes Dec 29, 2018
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 29, 2018
@jackysp jackysp merged commit 0e89c02 into pingcap:master Dec 29, 2018
yu34po pushed a commit to yu34po/tidb that referenced this pull request Jan 2, 2019
@jackysp @yu34po
*: clean up code for insert/update statement (pingcap#8867)
cbcb775
@jackysp jackysp deleted the batch_get branch February 11, 2019 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysu lysu lysu left review comments

@winkyao winkyao winkyao approved these changes

Assignees
No one assigned
Labels
component/metrics sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackysp @ngaut @lysu @winkyao