Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix panic and update error data when table has column in write only state (#8792) #8906

Merged

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Jan 2, 2019

What problem does this PR solve?

cherry-pick #8792

What is changed and how it works?

Check List

Tests


This change is Reviewable

@crazycs520
Copy link
Contributor Author

/run-all-tests tikv=release-2.1 tidb-test=release-2.1 pd=release-2.1

@crazycs520
Copy link
Contributor Author

/run-all-tests tikv=release-2.1 tidb-test=release-2.1 pd=release-2.1

@crazycs520
Copy link
Contributor Author

@winkyao @jackysp @lysu PTAL

@crazycs520
Copy link
Contributor Author

/run-all-tests tikv=release-2.1 tidb-test=release-2.1 pd=release-2.1

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 2, 2019
@crazycs520
Copy link
Contributor Author

/run-all-tests tikv=release-2.1 tidb-test=release-2.1 pd=release-2.1

@crazycs520
Copy link
Contributor Author

/run-unit-test tikv=release-2.1 tidb-test=release-2.1 pd=release-2.1

1 similar comment
@crazycs520
Copy link
Contributor Author

/run-unit-test tikv=release-2.1 tidb-test=release-2.1 pd=release-2.1

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 2, 2019
@zz-jason zz-jason merged commit e436a5a into pingcap:release-2.1 Jan 2, 2019
@crazycs520 crazycs520 deleted the panic-by-not-public-column-2.1 branch January 2, 2019 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants