Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domain, privilege: backport #8886 to release-2.1 #8948

Merged
merged 2 commits into from
Jan 8, 2019
Merged

domain, privilege: backport #8886 to release-2.1 #8948

merged 2 commits into from
Jan 8, 2019

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Jan 4, 2019 •
edited by c4pt0r
Loading

What problem does this PR solve?

Backport #8886 to release branch

What is changed and how it works?

Synchronously run FLUSH PRIVILEGES on GRANT.

Check List

Tests

  • Unit test

Code changes

  • Yes

Side effects

  • Possible performance regression (the server will do more work, since it will re-run FLUSH PRIVILEGES when it receives the etcd notification)
  • Increased code complexity (or actually decreased when you consider test simplification)

Related changes

  • Need to be included in the release note

This change is Reviewable

@morgo morgo mentioned this pull request Jan 4, 2019
Merged
@jackysp
Copy link
Member

jackysp commented Jan 7, 2019

/run-all-tests tidb-test=release-2.1 pd=release-2.1 tikv=release-2.1

@jackysp
Copy link
Member

jackysp commented Jan 7, 2019

PTAL @lysu

jackysp
jackysp reviewed Jan 7, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morgo morgo added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 7, 2019
zz-jason
zz-jason approved these changes Jan 7, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 7, 2019
@ngaut ngaut merged commit 936b988 into pingcap:release-2.1 Jan 8, 2019
@morgo morgo deleted the flush-2.1 branch January 8, 2019 02:26
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
component/privilege contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2. type/compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@morgo @jackysp @zz-jason @ngaut @sre-bot