-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: integrate plugin framework with TiDB #9006
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9006 +/- ##
==========================================
- Coverage 67.28% 67.25% -0.04%
==========================================
Files 371 371
Lines 75930 75972 +42
==========================================
+ Hits 51092 51094 +2
- Misses 20332 20367 +35
- Partials 4506 4511 +5
Continue to review full report at Codecov.
|
/run-all-tests |
@tiancaiamao PTAL it also contain a part of #8981 |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -12,7 +12,7 @@ path_to_add := $(addsuffix /bin,$(subst :,/bin:,$(GOPATH))) | |||
export PATH := $(path_to_add):$(PATH) | |||
|
|||
GO := GO111MODULE=on go | |||
GOBUILD := CGO_ENABLED=0 $(GO) build $(BUILD_FLAG) | |||
GOBUILD := CGO_ENABLED=1 $(GO) build $(BUILD_FLAG) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tennix PTAL if it will affect the docker image in k8s.
LGTM |
What problem does this PR solve?
following up #8788, integration plugin framework into TiDB
What is changed and how it works?
plugin_dir
andplugin_load
configloadCommonGlobalVarsSQL
be tweakable before boostrapCheck List
Tests
Code changes
Side effects
Related changes
This change is