Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support _tidb_rowid for table scan range (#8047) #9059

Merged
merged 1 commit into from
Jan 15, 2019
Merged

support _tidb_rowid for table scan range (#8047) #9059

merged 1 commit into from
Jan 15, 2019

Conversation

zz-jason
Copy link
Member

@zz-jason zz-jason commented Jan 15, 2019 •
edited
Loading

cherry pick #8047 to release 2.1

fix #9034

@zz-jason zz-jason added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner type/2.1 cherry-pick labels Jan 15, 2019
@XuHuaiyu XuHuaiyu mentioned this pull request Jan 15, 2019
Closed
XuHuaiyu
XuHuaiyu reviewed Jan 15, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu
Copy link
Contributor

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@XuHuaiyu XuHuaiyu added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 15, 2019
alivxxx
alivxxx approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 5118158 into pingcap:release-2.1 Jan 15, 2019
@zz-jason zz-jason deleted the cherrpick/2.1-rowid-range branch January 15, 2019 05:04
@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@alivxxx alivxxx alivxxx approved these changes

@eurekaka eurekaka Awaiting requested review from eurekaka

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zz-jason @XuHuaiyu @alivxxx @yu34po